Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Logs] Remove the in-development isolating log record processor #4301

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

pellared
Copy link
Member

@pellared pellared commented Nov 19, 2024

Changes

Remove the in-development isolating log record processor introduced in #4062 by myself.

Reasons

According to the most recent discussions regarding Enabled SDK implementation (see: #4207) there looks to be a tendency to lean towards simplifying the SDK.
The current preference is that the users should use the collector for setting up multiple log processing pipelines. E.g.

To be honest, the design to prioritize multiple independent logging pipelines, each with their own filter, doesn't resonate with me. Its too different from the other signals, and adds complexity for what I consider to be a niche use case. I think those types of use cases are better served by the collector, instead of adding the burden to all the language implementations.

The users can still create workarounds e.g. by deep cloning of a ReadWriteLogRecord and make log record processor decorators.
There is no need to deprecate the isolating processor as AFAIK nobody has implemented it (there was only a prototype for OTel Go: open-telemetry/opentelemetry-go-contrib#5861).

@pellared pellared added the spec:logs Related to the specification/logs directory label Nov 19, 2024
@pellared pellared marked this pull request as ready for review November 19, 2024 14:23
@pellared pellared requested review from a team as code owners November 19, 2024 14:23
Copy link

github-actions bot commented Dec 3, 2024

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Dec 3, 2024
@trask trask removed the Stale label Dec 3, 2024
@pellared
Copy link
Member Author

pellared commented Dec 3, 2024

@carlosalberto, I guess this can be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spec:logs Related to the specification/logs directory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants