Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Body instead of Payload in Events SDK #4158

Merged
merged 4 commits into from
Jul 29, 2024
Merged

Use Body instead of Payload in Events SDK #4158

merged 4 commits into from
Jul 29, 2024

Conversation

pellared
Copy link
Member

@pellared pellared commented Jul 24, 2024 •
edited
Loading

Leftover after #4035 which changed Payload into Body in Events API

@pellared pellared added spec:logs Related to the specification/logs directory clarification clarify ambiguity in specification labels Jul 24, 2024
@pellared pellared requested review from a team July 24, 2024 07:35
@pellared pellared added the editorial Editorial changes only (typos, changelog, ...). No content-related changes of any kind. label Jul 24, 2024
@pellared pellared changed the title [Events] Use Body instead of Payload Use Body instead of Payload in Events SDK Jul 24, 2024
@pellared
Copy link
Member Author

CC @martinkuba

@carlosalberto carlosalberto merged commit 64e772d into open-telemetry:main Jul 29, 2024
6 checks passed
@pellared pellared deleted the ev-body branch July 29, 2024 14:22
carlosalberto pushed a commit to carlosalberto/opentelemetry-specification that referenced this pull request Oct 31, 2024
@pellared
Use Body instead of Payload in Events SDK (open-telemetry#4158)
ff20767 
Leftover after
open-telemetry#4035
which changed `Payload` into `Body` in Events API
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JamieDanielson JamieDanielson JamieDanielson approved these changes

@MrAlias MrAlias MrAlias approved these changes

@martinkuba martinkuba martinkuba approved these changes

@lmolkova lmolkova lmolkova approved these changes

@bogdandrutu bogdandrutu bogdandrutu approved these changes

@trask trask trask approved these changes

Assignees

@carlosalberto carlosalberto

Labels
clarification clarify ambiguity in specification editorial Editorial changes only (typos, changelog, ...). No content-related changes of any kind. spec:logs Related to the specification/logs directory
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@pellared @trask @bogdandrutu @lmolkova @martinkuba @MrAlias @JamieDanielson @carlosalberto