Clarify that STDOUT exporter format is unspecified #3935
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrAlias
added
spec:metrics
MrAlias
force-pushed
the
unspecified-out-fmt
branch
from
4adb602 to
b22f796
Compare
|
This approach has not been decided on: #3565 |
cijothomas
reviewed
Mar 12, 2024
cijothomas
reviewed
Mar 12, 2024
|
@MrAlias Do you plan to re-open this, and add this language to the spec wording for stdout? This looks a good addition! |
👍 |
cijothomas
approved these changes
Mar 13, 2024
reyang
reviewed
Mar 13, 2024
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
tigrannajaryan
changed the title
| @@ -10,6 +10,12 @@ linkTitle: Stdout | |||
| Exporter](../sdk.md#logrecordexporter) which outputs the logs to | |||
| stdout/console. | |||
|
|
|||
| The output format of the exporter is unspecified. The exporter SHOULD be | |||
There was a problem hiding this comment.
Since we actually specify some requirements for the format (e.g. that it is not performance optimized) I wonder if it is better to say:
Suggested change
| The output format of the exporter is unspecified. The exporter SHOULD be | |
| The output format of the exporter is implementation-dependant. The exporter SHOULD be |
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #3565
Changes
The output format of the STDOUT exporter is unique to each OpenTelemetry language implementation. Reflect this in the specification and add normative requirements and suggestions for language implementations to document the exporter appropriately.