Add service to glossary #3815
Closed
Add service to glossary #3815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: svrnm <[email protected]>
Signed-off-by: svrnm <[email protected]>
Signed-off-by: svrnm <[email protected]>
joaopgrassi
approved these changes
Jan 11, 2024
reyang
approved these changes
Jan 11, 2024
MrAlias
approved these changes
Jan 11, 2024
jack-berg
approved these changes
Jan 11, 2024
tigrannajaryan
approved these changes
Jan 11, 2024
yurishkuro
reviewed
Jan 11, 2024
Co-authored-by: Yuri Shkuro <[email protected]>
|
Do we might want to hold off on merging this, given now we want to revert the change in the semantic conventions repo? open-telemetry/semantic-conventions#638 |
yeah, looks like this is blocked now |
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
|
will close this PR because of open-telemetry/semantic-conventions#638 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2050
Changes
Adds @jack-berg's description of what a service is from open-telemetry/semantic-conventions#630 to the spec glossary.
cc @joaopgrassi