Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename process.runtime.jvm.buffer.* metrics to process.runtime.jvm.buffers.* #3482

Closed
wants to merge 1 commit into from

Conversation

trask
Copy link
Member

@trask trask commented May 8, 2023

Related to #3429 (comment)

Changes

Renames process.runtime.jvm.buffer.* metrics to process.runtime.jvm.buffers.*

Based on guidance from https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/metrics/semantic_conventions/README.md#pluralization.

And similar to system.processes.*.

@trask trask force-pushed the buffer-to-buffers branch from c35c841 to 1b73f2f Compare May 8, 2023 21:19
@trask trask marked this pull request as ready for review May 8, 2023 21:19
@trask trask requested review from a team May 8, 2023 21:19
@trask
Copy link
Member Author

trask commented May 8, 2023

I realized I have more questions about these metrics, so closing this for now.

@trask trask closed this May 8, 2023
@trask trask deleted the buffer-to-buffers branch May 8, 2023 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants