-
Notifications
You must be signed in to change notification settings - Fork 894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename two JVM runtime metrics #3472
Conversation
I'm guessing this is done to simply be more descriptive - is that it, or is there another reason? |
sorry, I added reason into description above now. also, as I was doing that, I revisited and now wondering if these might be better:
I think this similarly avoids the issue about "utilization since last export", and they also match the MBean attribute names that they're sourced from. |
@trask heads up - most likely this PR will be closed, and we'll ask you to resubmit the PR in a new repo, please refer to #3474 (comment). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please move this PR to https://github.com/open-telemetry/semantic-conventions
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
Closing in favor of issues: open-telemetry/semantic-conventions#42 and open-telemetry/semantic-conventions#41 |
Changes
Renames 2 JVM runtime metrics:
process.runtime.jvm.cpu.utilization
-->process.runtime.jvm.cpu.recent_utilization
process.runtime.jvm.system.cpu.utilization
-->process.runtime.jvm.system.cpu.recent_utilization
This is to make clear that these are gauges (utilization for "some" recent period of time) as opposed to measures of utilization since the last metric export/scrape.
EDIT: maybe
process.runtime.jvm.cpu.load
andprocess.runtime.jvm.system.cpu.load
would also be good? (and matches the MBean attribute names that these are sourced from)