Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename two JVM runtime metrics #3472

Closed
wants to merge 3 commits into from
Closed

Conversation

trask
Copy link
Member

@trask trask commented May 5, 2023

Changes

Renames 2 JVM runtime metrics:

  • process.runtime.jvm.cpu.utilization --> process.runtime.jvm.cpu.recent_utilization
  • process.runtime.jvm.system.cpu.utilization --> process.runtime.jvm.system.cpu.recent_utilization

This is to make clear that these are gauges (utilization for "some" recent period of time) as opposed to measures of utilization since the last metric export/scrape.

EDIT: maybe process.runtime.jvm.cpu.load and process.runtime.jvm.system.cpu.load would also be good? (and matches the MBean attribute names that these are sourced from)

@trask trask marked this pull request as ready for review May 5, 2023 03:29
@trask trask requested review from a team May 5, 2023 03:29
@carlosalberto
Copy link
Contributor

I'm guessing this is done to simply be more descriptive - is that it, or is there another reason?

@trask
Copy link
Member Author

trask commented May 8, 2023

I'm guessing this is done to simply be more descriptive - is that it, or is there another reason?

sorry, I added reason into description above now.

also, as I was doing that, I revisited and now wondering if these might be better:

  • process.runtime.jvm.cpu.load
  • process.runtime.jvm.system.cpu.load

I think this similarly avoids the issue about "utilization since last export", and they also match the MBean attribute names that they're sourced from.

@arminru arminru added area:semantic-conventions Related to semantic conventions spec:metrics Related to the specification/metrics directory labels May 8, 2023
@reyang
Copy link
Member

reyang commented May 9, 2023

@trask heads up - most likely this PR will be closed, and we'll ask you to resubmit the PR in a new repo, please refer to #3474 (comment).

Copy link
Contributor

@jsuereth jsuereth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@github-actions
Copy link

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label May 20, 2023
@trask
Copy link
Member Author

trask commented May 23, 2023

@trask trask closed this May 23, 2023
@trask trask deleted the recent branch May 23, 2023 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:semantic-conventions Related to semantic conventions spec:metrics Related to the specification/metrics directory Stale
Projects
Development

Successfully merging this pull request may close these issues.

8 participants