add k8s.pod.hostname #3201
Closed
add k8s.pod.hostname #3201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
alburthoffman
force-pushed
the
k8s_pod_spec_host
branch
from
b81ff41 to
86d242f
Compare
|
@alburthoffman please sign the CLA |
arminru
added
area:semantic-conventions
alburthoffman
force-pushed
the
k8s_pod_spec_host
branch
from
95d7eb1 to
a166884
Compare
|
@dmitryax could u help with the pending workflow? it waits for approval.... |
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Changes
Spans from our client contain a host attribute, which is pod's hostname in the metadata.
And the bad news is pod's name is a little different from hostname.
We want to associate pod metadata based on the host attribute. Based on k8s documents, pod.spec.hostname might be different with pod.name. refer to https://github.com/alburthoffman/opentelemetry-collector-contrib/blob/main/processor/k8sattributesprocessor/internal/kube/client.go#L288
But since k8s processor only support pod name, we could not do this.
Related issues # open-telemetry/opentelemetry-collector-contrib#18494