Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Cosmosdb attributes for open telemetry #3097

Merged
merged 20 commits into from
Mar 21, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,8 @@ release.
([#3190](https://github.com/open-telemetry/opentelemetry-specification/pull/3190))
- Expand the declaration of `pool.name`.
([#3050](https://github.com/open-telemetry/opentelemetry-specification/pull/3050))
- Define attributes collected for `cosmosdb` by Cosmos DB SDK
([#3097](https://github.com/open-telemetry/opentelemetry-specification/pull/3097))

### Compatibility

Expand Down
91 changes: 91 additions & 0 deletions semantic_conventions/trace/database.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -402,6 +402,96 @@ groups:
value MUST NOT be set.
examples: ['public.users', 'customers']

- id: db.cosmosdb
type: span
extends: db
prefix: db.cosmosdb
brief: >
Call-level attributes for Cosmos DB.
attributes:
- id: client_id
type: string
brief: Unique Cosmos client instance id.
examples: '3ba4827d-4422-483f-b59f-85b74211c11d'
- id: operation_type
type:
allow_custom_values: true
members:
- id: invalid
value: 'Invalid'
- id: create
value: 'Create'
- id: patch
value: 'Patch'
- id: read
value: 'Read'
- id: read_feed
value: 'ReadFeed'
- id: delete
value: 'Delete'
- id: replace
value: 'Replace'
- id: execute
value: 'Execute'
- id: query
value: 'Query'
- id: head
value: 'Head'
- id: head_feed
value: 'HeadFeed'
- id: upsert
value: 'Upsert'
- id: batch
value: 'Batch'
- id: query_plan
value: 'QueryPlan'
- id: execute_javascript
value: 'ExecuteJavaScript'
brief: CosmosDB Operation Type.
requirement_level:
conditionally_required: when performing one of the operations in this list
- ref: user_agent.original
- id: connection_mode
type:
allow_custom_values: false
members:
- id: gateway
value: 'gateway'
brief: Gateway (HTTP) connections mode
- id: direct
value: 'direct'
brief: Direct connection.
brief: Cosmos client connection mode.
requirement_level:
conditionally_required: if not `direct` (or pick gw as default)
- id: container
type: string
brief: Cosmos DB container name.
requirement_level:
conditionally_required: if available
examples: 'anystring'
- id: request_content_length
sourabh1007 marked this conversation as resolved.
Show resolved Hide resolved
type: int
brief: Request payload size in bytes
- id: status_code
type: int
brief: Cosmos DB status code.
examples: [200, 201]
requirement_level:
conditionally_required: if response was received
- id: sub_status_code
type: int
brief: Cosmos DB sub status code.
examples: [1000, 1002]
requirement_level:
conditionally_required: when response was received and contained sub-code.
- id: request_charge
type: double
brief: RU consumed for that operation
examples: [46.18, 1.0]
requirement_level:
conditionally_required: when available

- id: db.tech
type: span
brief: "Semantic convention group for specific technologies"
Expand All @@ -410,3 +500,4 @@ groups:
- include: 'db.redis'
- include: 'db.mongodb'
- include: 'db.sql'
- include: 'db.cosmosdb'
75 changes: 75 additions & 0 deletions specification/trace/semantic_conventions/database.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,12 @@
- [Call-level attributes](#call-level-attributes)
* [Call-level attributes for specific technologies](#call-level-attributes-for-specific-technologies)
+ [Cassandra](#cassandra)
+ [Microsoft Azure Cosmos DB Attributes](#microsoft-azure-cosmos-db-attributes)
- [Examples](#examples)
* [MySQL](#mysql)
* [Redis](#redis)
* [MongoDB](#mongodb)
* [Microsoft Azure Cosmos DB](#microsoft-azure-cosmos-db)

<!-- tocstop -->

Expand Down Expand Up @@ -215,6 +217,58 @@ Separated for clarity.
**[1]:** This mirrors the db.sql.table attribute but references cassandra rather than sql. It is not recommended to attempt any client-side parsing of `db.statement` just to get this property, but it should be set if it is provided by the library being instrumented. If the operation is acting upon an anonymous table, or more than one table, this value MUST NOT be set.
<!-- endsemconv -->

#### Microsoft Azure Cosmos DB Attributes

Cosmos DB instrumentation includes call-level (public API) surface spans and network spans. Depending on the connection mode (Gateway or Direct), network-level spans may also be created.

<!-- semconv db.cosmosdb -->
| Attribute | Type | Description | Examples | Requirement Level |
|---|---|---|---|---|
| `db.cosmosdb.client_id` | string | Unique Cosmos client instance id. | `3ba4827d-4422-483f-b59f-85b74211c11d` | Recommended |
| `db.cosmosdb.operation_type` | string | CosmosDB Operation Type. | `Invalid` | Conditionally Required: [1] |
| `db.cosmosdb.connection_mode` | string | Cosmos client connection mode. | `gateway` | Conditionally Required: if not `direct` (or pick gw as default) |
| `db.cosmosdb.container` | string | Cosmos DB container name. | `anystring` | Conditionally Required: if available |
| `db.cosmosdb.request_content_length` | int | Request payload size in bytes | | Recommended |
| `db.cosmosdb.status_code` | int | Cosmos DB status code. | `200`; `201` | Conditionally Required: if response was received |
| `db.cosmosdb.sub_status_code` | int | Cosmos DB sub status code. | `1000`; `1002` | Conditionally Required: [2] |
| `db.cosmosdb.request_charge` | double | RU consumed for that operation | `46.18`; `1.0` | Conditionally Required: when available |
| `user_agent.original` | string | Value of the [HTTP User-Agent](https://www.rfc-editor.org/rfc/rfc9110.html#field.user-agent) header sent by the client. | `CERN-LineMode/2.15 libwww/2.17b3` | Recommended |

**[1]:** when performing one of the operations in this list

**[2]:** when response was received and contained sub-code.

`db.cosmosdb.operation_type` has the following list of well-known values. If one of them applies, then the respective value MUST be used, otherwise a custom value MAY be used.

| Value | Description |
|---|---|
| `Invalid` | invalid |
| `Create` | create |
| `Patch` | patch |
| `Read` | read |
| `ReadFeed` | read_feed |
| `Delete` | delete |
| `Replace` | replace |
| `Execute` | execute |
| `Query` | query |
| `Head` | head |
| `HeadFeed` | head_feed |
| `Upsert` | upsert |
| `Batch` | batch |
| `QueryPlan` | query_plan |
| `ExecuteJavaScript` | execute_javascript |

`db.cosmosdb.connection_mode` MUST be one of the following:

| Value | Description |
|---|---|
| `gateway` | Gateway (HTTP) connections mode |
| `direct` | Direct connection. |
<!-- endsemconv -->

In addition to Cosmos DB attributes, all spans include
`az.namespace` attribute representing Azure Resource Provider namespace that MUST be equal to `Microsoft.DocumentDB`.

## Examples

### MySQL
Expand Down Expand Up @@ -268,3 +322,24 @@ Furthermore, `db.name` is not specified as there is no database name in Redis an
| `db.statement` | not set |
| `db.operation` | `"findAndModify"` |
| `db.mongodb.collection` | `"products"` |

### Microsoft Azure Cosmos DB

| Key | Value |
|:-------------------------------------| :------------------- |
| Span name | `"ReadItemsAsync"` |
| `kind` | `"internal"` |
| `az.namespace` | `"Microsoft.DocumentDB"` |
| `db.system` | `"cosmosdb"` |
| `db.name` | `"database name"` |
| `db.operation` | `"ReadItemsAsync"` |
| `net.peer.name` | `"account.documents.azure.com"` |
| `db.cosmosdb.client_id` | `3ba4827d-4422-483f-b59f-85b74211c11d` |
| `db.cosmosdb.operation_type` | `Read` |
| `user_agent.original` | `cosmos-netstandard-sdk/3.31.2|1|X64|Linux 5.4.0-1095-azure 101 18|.NET 6.0.2|N|appname` |
| `db.cosmosdb.connection_mode` | `"Direct"` |
| `db.cosmosdb.container` | `"container name"` |
| `db.cosmosdb.request_content_length` | `20` |
| `db.cosmosdb.status_code` | `201` |
| `db.cosmosdb.sub_status_code` | `0` |
| `db.cosmosdb.request_charge` | `7.43` |