-
Notifications
You must be signed in to change notification settings - Fork 897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OpenCensus migration plan #3015
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dashpole
force-pushed
the
oc_migration_plan
branch
2 times, most recently
from
December 6, 2022 19:40
291de01
to
5489276
Compare
dashpole
force-pushed
the
oc_migration_plan
branch
from
December 6, 2022 19:44
5489276
to
cc7be47
Compare
jack-berg
reviewed
Dec 13, 2022
dashpole
force-pushed
the
oc_migration_plan
branch
from
December 14, 2022 16:44
a94a21d
to
0e6ba76
Compare
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
MrAlias
approved these changes
Jan 12, 2023
dashpole
force-pushed
the
oc_migration_plan
branch
from
January 12, 2023 15:35
526c9b1
to
5938274
Compare
jack-berg
approved these changes
Jan 12, 2023
dashpole
force-pushed
the
oc_migration_plan
branch
2 times, most recently
from
January 12, 2023 16:37
787d805
to
6f22e56
Compare
dashpole
requested review from
MrAlias and
jack-berg
and removed request for
MrAlias
January 12, 2023 19:00
jsuereth
approved these changes
Jan 12, 2023
carlosalberto
approved these changes
Jan 16, 2023
@dashpole Changelog entry please. Otherwise it looks we are ready to go. |
dashpole
force-pushed
the
oc_migration_plan
branch
from
January 17, 2023 15:26
41fc264
to
b127852
Compare
@carlosalberto Done |
reyang
reviewed
Jan 17, 2023
reyang
approved these changes
Jan 17, 2023
Co-authored-by: Reiley Yang <[email protected]>
carlosalberto
pushed a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1175
Supersedes #2730.
Follow-up to #2979
Changes
Motivation
We have defined what OpenCensus metric and trace bridges, but don't have anywhere with recommendations on how to use them to migrate from OpenCensus to OpenTelemetry. This adds a description of how users and library authors can migrate to OpenTelemetry.
Removed
Added
Changed
The alternative to adding OC binary propagation directly to grpc instrumentation would be to introduce a binary propagator interface (similar to TextMapPropagator) in OTel. Given that this is just for a migration, that likely isn't an appropriately scoped change.