-
Notifications
You must be signed in to change notification settings - Fork 895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor grammar changes, addressed feedback from @haf #289
Merged
SergeyKanzhelev
merged 13 commits into
open-telemetry:master
from
SergeyKanzhelev:addressFeedback
Oct 10, 2019
Merged
Minor grammar changes, addressed feedback from @haf #289
SergeyKanzhelev
merged 13 commits into
open-telemetry:master
from
SergeyKanzhelev:addressFeedback
Oct 10, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SergeyKanzhelev
requested review from
AloisReitbauer,
bogdandrutu,
c24t,
carlosalberto,
iredelmeier,
reyang,
songy23,
tedsuo,
tigrannajaryan and
yurishkuro
as code owners
October 7, 2019 19:16
c24t
approved these changes
Oct 9, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Content looks good, I thought a PR named "minor grammar changes" was a good place to leave a bunch of minor grammar nit comments.
Co-Authored-By: Chris Kleinknecht <[email protected]>
Co-Authored-By: Chris Kleinknecht <[email protected]>
Co-Authored-By: Chris Kleinknecht <[email protected]>
Co-Authored-By: Chris Kleinknecht <[email protected]>
Co-Authored-By: Chris Kleinknecht <[email protected]>
Co-Authored-By: Chris Kleinknecht <[email protected]>
Co-Authored-By: Chris Kleinknecht <[email protected]>
Co-Authored-By: Chris Kleinknecht <[email protected]>
bogdandrutu
approved these changes
Oct 9, 2019
SergeyKanzhelev
added a commit
to SergeyKanzhelev/opentelemetry-specification
that referenced
this pull request
Feb 18, 2020
* addressed feedback from @haf * Update specification/overview.md Co-Authored-By: Chris Kleinknecht <[email protected]> * Update specification/overview.md Co-Authored-By: Chris Kleinknecht <[email protected]> * Update specification/overview.md Co-Authored-By: Chris Kleinknecht <[email protected]> * Update specification/overview.md Co-Authored-By: Chris Kleinknecht <[email protected]> * Update specification/overview.md Co-Authored-By: Chris Kleinknecht <[email protected]> * Update specification/overview.md Co-Authored-By: Chris Kleinknecht <[email protected]> * Update specification/overview.md Co-Authored-By: Chris Kleinknecht <[email protected]> * Update specification/overview.md Co-Authored-By: Chris Kleinknecht <[email protected]>
carlosalberto
pushed a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 31, 2024
* addressed feedback from @haf * Update specification/overview.md Co-Authored-By: Chris Kleinknecht <[email protected]> * Update specification/overview.md Co-Authored-By: Chris Kleinknecht <[email protected]> * Update specification/overview.md Co-Authored-By: Chris Kleinknecht <[email protected]> * Update specification/overview.md Co-Authored-By: Chris Kleinknecht <[email protected]> * Update specification/overview.md Co-Authored-By: Chris Kleinknecht <[email protected]> * Update specification/overview.md Co-Authored-By: Chris Kleinknecht <[email protected]> * Update specification/overview.md Co-Authored-By: Chris Kleinknecht <[email protected]> * Update specification/overview.md Co-Authored-By: Chris Kleinknecht <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressed feedback from #283. Sentences structure, no semantics change.