Improve conversion of resource attributes to/from prometheus #2381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…esource attributes
Aneurysm9
reviewed
Feb 24, 2022
bogdandrutu
reviewed
Feb 25, 2022
dashpole
force-pushed
the
prom_resource
branch
from
af45428 to
0fb5fca
Compare
Aneurysm9
approved these changes
Feb 25, 2022
Co-authored-by: Anthony Mirabella <[email protected]>
bogdandrutu
approved these changes
Mar 1, 2022
gouthamve
reviewed
Mar 2, 2022
jsuereth
approved these changes
Mar 4, 2022
jmacd
approved these changes
Mar 4, 2022
This was referenced Mar 5, 2022
carlosalberto
pushed a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 31, 2024
…lemetry#2381) * update resource attributes used by prometheus, and round-trip other resource attributes * address feedbck * address feedbck * map target_info to resource, and use service.instance.id for instance * formatting * be clear on metric family vs metric point * Update specification/metrics/datamodel.md Co-authored-by: Anthony Mirabella <[email protected]> * change deliniator to / * fix formatting Co-authored-by: Anthony Mirabella <[email protected]> Co-authored-by: Bogdan Drutu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1782
Related: open-telemetry/opentelemetry-collector-contrib#7081
Changes
Job and Instance <-> Resources Attributes
(Discussion in open-telemetry/opentelemetry-collector-contrib#7081)
Job
Current:
jobprom label ->jobresource attribute ->jobprom label.New:
jobprom label ->service.nameresource attribute ->jobprom label.This will improve the OTLP receiver (and others) -> Prometheus remote write exporter path, since
service.nameis more likely to be present thanjobon metrics not originating from prometheus receivers.Instance
Current:
instanceprom label ->instanceresource attribute ->instanceprom label.New:
instanceprom label ->service.instance.idresource attributes ->instanceprom label.This will improve the OTLP receiver (and others) -> Prometheus remote write exporter path, since
service.instance.idare more likely to be present thaninstanceon metrics not originating from prometheus receivers.This will also improve the Prometheus receiver -> OTLP (and other) exporter path, since
net.host.name+net.host.portalign better with semantic conventions thanhost.name+portorinstance. As discussed in the linked issue, http metric conventions are the best fit for these attributes.Other Resource Attributes <-> target_info
OpenMetrics explicitly defines a way for exporters which discover their own resource information to send metadata with a batch of Prometheus metrics: the target_info metric. This PR describes how this metric SHOULD be used, although it doesn't mandate its use.
cc @Aneurysm9 @jmacd @jsuereth @bogdandrutu @djaglowski