Refactor the Metrics API specification for instruments #2360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arminru
reviewed
Feb 18, 2022
arminru
added
area:api
arminru
reviewed
Feb 18, 2022
pirgeo
reviewed
Feb 22, 2022
Co-authored-by: Georg Pirklbauer <[email protected]>
jack-berg
approved these changes
Feb 23, 2022
added 3 commits
February 24, 2022 07:47
…pecification into jmacd/refactor_api
…ication into jmacd/refactor_api
MrAlias
approved these changes
Feb 28, 2022
…ication into jmacd/refactor_api
…pecification into jmacd/refactor_api
carlosalberto
pushed a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This consolidates several sections of text that were duplicated between the asynchronous and synchronous instrument specifications. This refactoring adds sections to the TOC where there were previously only named sections. This makes navigating easier and makes the structure of the general requirements clear to the reader.
There are NO SPECIFICATION CHANGES in this PR, only movement and less duplication. One approximately-duplicate paragraph was removed in favor of another pre-existing statement, both relating to duplicate observations from async callbacks.
Part of #2350.