Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify SDK must apply a default aggregation if not specified. #2163

Merged
merged 3 commits into from
Nov 29, 2021
Merged

Clarify SDK must apply a default aggregation if not specified. #2163

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
eb97d51
Clarify SDK must apply a default aggregation if not specified.
anuraaga Nov 24, 2021
84dfc44
Merge branch 'main' into aggregation-default-must
reyang Nov 25, 2021
b51c58c
Merge branch 'main' into aggregation-default-must
jmacd Nov 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion specification/metrics/sdk.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ are the inputs:
* The `extra dimensions` which come from Baggage/Context (optional). If not
provided, no extra dimension will be used. Please note that this only
applies to [synchronous Instruments](./api.md#synchronous-instrument).
* The `aggregation` (optional) to be used. If not provided, the SDK SHOULD
* The `aggregation` (optional) to be used. If not provided, the SDK MUST
jmacd marked this conversation as resolved.
Show resolved Hide resolved
apply a [default aggregation](#default-aggregation). If the aggregation
outputs metric points that use aggregation temporality (e.g. Histogram,
Sum), the SDK SHOULD handle the aggregation temporality based on the
Expand Down