Change Span specification to focus more on capabilities. #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdandrutu
requested review from
AloisReitbauer,
c24t,
carlosalberto,
iredelmeier,
reyang,
SergeyKanzhelev,
songy23,
tedsuo and
yurishkuro
as code owners
arminru
approved these changes
Jul 18, 2019
|
|
||
| API MUST also provide an overload that accepts a [`Link` interface](#link). This | ||
| overload allows instrumentation to supply a lazily calculated `Link`. | ||
| #### Set Status |
There was a problem hiding this comment.
Is the span status supposed to be any custom user-defined string, or will an enum or constants be defined?
There was a problem hiding this comment.
I did not get to the Status API. I will clarify in the followup PR.
Co-Authored-By: Armin Ruech <[email protected]>
Co-Authored-By: Armin Ruech <[email protected]>
Co-Authored-By: Armin Ruech <[email protected]>
Co-Authored-By: Armin Ruech <[email protected]>
Co-Authored-By: Armin Ruech <[email protected]>
Co-Authored-By: Armin Ruech <[email protected]>
Co-Authored-By: Armin Ruech <[email protected]>
Co-Authored-By: Armin Ruech <[email protected]>
Co-Authored-By: Armin Ruech <[email protected]>
Co-Authored-By: Armin Ruech <[email protected]>
Co-Authored-By: Armin Ruech <[email protected]>
reyang
reviewed
Jul 18, 2019
yurishkuro
reviewed
Jul 19, 2019
specification/tracing-api.md
Outdated
|
|
||
| Retrieve the `Span`s `SpanContext` | ||
| A `Span` MUST have the ability to return the `SpanContext` associated with it. | ||
| The returned value MUST be the same for the entire Span lifetime. |
There was a problem hiding this comment.
Isn't sampled flag a part of span context? In some implementations it could change during the lifetime of a span. What is the actual requirement here?
There was a problem hiding this comment.
I think the current PR does not change the behavior. I do understand your requirement but we should have a separate discussion about this. Filed #189 to track this separately.
specification/tracing-api.md
Outdated
| - An API to record lazy initialized links. This can be implemented by providing | ||
| a `Link` interface or a concrete `Link` definition and a `LinkFormatter`. If | ||
| the language supports overloads then this SHOULD be called `AddLink` otherwise | ||
| `AddLazyLink` may be consider. |
There was a problem hiding this comment.
is there a ticket describing the use case for "lazy links"?
There was a problem hiding this comment.
This is mostly for the attributes, for example the values may be lazily formatted.
c24t
reviewed
Jul 19, 2019
|
This reads much better :). I was writing up a whole thing about how in Erlang, with immutable variables, SpanContext maps fine to how the API is defined but the Span's themselves don't. The actual spans are stored in a mutable table keyed on the spancontext. so calls like |
reyang
reviewed
Jul 19, 2019
Co-Authored-By: Chris Kleinknecht <[email protected]>
Co-Authored-By: Chris Kleinknecht <[email protected]>
|
Waiting for other approves before I will merge. |
reyang
approved these changes
Jul 22, 2019
|
I will wait until tomorrow to merge this, if no comments :) |
carlosalberto
approved these changes
Jul 23, 2019
c24t
approved these changes
Jul 24, 2019
SergeyKanzhelev
pushed a commit
to SergeyKanzhelev/opentelemetry-specification
that referenced
this pull request
Feb 18, 2020
…try#184) * Change Span specification to focus more on capabilities. * Update specification/tracing-api.md Co-Authored-By: Armin Ruech <[email protected]> * Update specification/tracing-api.md Co-Authored-By: Armin Ruech <[email protected]> * Update specification/tracing-api.md Co-Authored-By: Armin Ruech <[email protected]> * Update specification/tracing-api.md Co-Authored-By: Armin Ruech <[email protected]> * Update specification/tracing-api.md Co-Authored-By: Armin Ruech <[email protected]> * Update specification/tracing-api.md Co-Authored-By: Armin Ruech <[email protected]> * Update specification/tracing-api.md Co-Authored-By: Armin Ruech <[email protected]> * Update specification/tracing-api.md Co-Authored-By: Armin Ruech <[email protected]> * Update specification/tracing-api.md Co-Authored-By: Armin Ruech <[email protected]> * Update specification/tracing-api.md Co-Authored-By: Armin Ruech <[email protected]> * Update specification/tracing-api.md Co-Authored-By: Armin Ruech <[email protected]> * Update specification/tracing-api.md Co-Authored-By: Chris Kleinknecht <[email protected]> * Update specification/tracing-api.md Co-Authored-By: Chris Kleinknecht <[email protected]> * Fix comments from review. * Clarify that only one attribute,event,link is recorded.
carlosalberto
pushed a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 31, 2024
…try#184) * Change Span specification to focus more on capabilities. * Update specification/tracing-api.md Co-Authored-By: Armin Ruech <[email protected]> * Update specification/tracing-api.md Co-Authored-By: Armin Ruech <[email protected]> * Update specification/tracing-api.md Co-Authored-By: Armin Ruech <[email protected]> * Update specification/tracing-api.md Co-Authored-By: Armin Ruech <[email protected]> * Update specification/tracing-api.md Co-Authored-By: Armin Ruech <[email protected]> * Update specification/tracing-api.md Co-Authored-By: Armin Ruech <[email protected]> * Update specification/tracing-api.md Co-Authored-By: Armin Ruech <[email protected]> * Update specification/tracing-api.md Co-Authored-By: Armin Ruech <[email protected]> * Update specification/tracing-api.md Co-Authored-By: Armin Ruech <[email protected]> * Update specification/tracing-api.md Co-Authored-By: Armin Ruech <[email protected]> * Update specification/tracing-api.md Co-Authored-By: Armin Ruech <[email protected]> * Update specification/tracing-api.md Co-Authored-By: Chris Kleinknecht <[email protected]> * Update specification/tracing-api.md Co-Authored-By: Chris Kleinknecht <[email protected]> * Fix comments from review. * Clarify that only one attribute,event,link is recorded.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes a subset of the Span API to the agreed model in #165. The rest of the changes will be added in a different PR, trying to keep this PR small so feedback can be addressed faster.
Updates #165