Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release v1.4.0 #1744

Merged
merged 4 commits into from
Jun 7, 2021
Merged

Release v1.4.0 #1744

merged 4 commits into from
Jun 7, 2021

Conversation

carlosalberto
Copy link
Contributor

@carlosalberto carlosalberto commented Jun 4, 2021 •
edited
Loading

@carlosalberto carlosalberto requested review from a team June 4, 2021 12:10
@Oberon00
Copy link
Member

Oberon00 commented Jun 4, 2021 •
edited
Loading

I think @reyang mentioned that he'd like to have #1733 in this release. Is this feasible?

See https://cloud-native.slack.com/archives/C01N7PP1THC/p1622564456010200
(#1731 which was also mentioned there is already merged)

tigrannajaryan
tigrannajaryan approved these changes Jun 4, 2021
View reviewed changes
Copy link
Member

@tigrannajaryan tigrannajaryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
We will need to merge open-telemetry/opentelemetry.io#599 after the release.

@carlosalberto
Copy link
Contributor Author

Ping @reyang

@reyang
Copy link
Member

reyang commented Jun 4, 2021 •
edited
Loading

Ping @reyang

#1733 is ready to be merged (it is an editorial change).
And yes it'll be great to have it in the 1.4.0 release (not a blocker, but a nice-to-have clarification).

reyang
reyang approved these changes Jun 4, 2021
View reviewed changes
Copy link
Member

@reyang reyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@carlosalberto
Copy link
Contributor Author

Let's merge/release on early Monday, to avoid weekend surprises.

arminru
arminru approved these changes Jun 7, 2021
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@jsuereth
Copy link
Contributor

jsuereth commented Jun 7, 2021

Would you be ok merging #1728 before releasing 1.4?

At a minimum, we want OTLP metrics marked stable in 1.4

@carlosalberto carlosalberto merged commit ea26ef7 into open-telemetry:main Jun 7, 2021
carlosalberto added a commit to carlosalberto/opentelemetry-specification that referenced this pull request Oct 31, 2024
@carlosalberto
Release v1.4.0 (open-telemetry#1744)
7b579ea
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reyang reyang reyang approved these changes

@arminru arminru arminru approved these changes

@tigrannajaryan tigrannajaryan tigrannajaryan approved these changes

@bogdandrutu bogdandrutu bogdandrutu approved these changes

Assignees

@yurishkuro yurishkuro

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@carlosalberto @Oberon00 @reyang @jsuereth @bogdandrutu @tigrannajaryan @arminru @yurishkuro