Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Baggage propagator to reference API Propagators #1575

Merged
merged 5 commits into from
Mar 24, 2021
Merged

Update Baggage propagator to reference API Propagators #1575

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
00b6b14
Update Baggage propagator to ref API Propagators
MrAlias Mar 23, 2021
77f6dee
Add changes to changelog
MrAlias Mar 23, 2021
10679da
Fix PR number and links
MrAlias Mar 23, 2021
7a47f79
Merge branch 'main' into fix-1526
MrAlias Mar 23, 2021
a828557
Merge branch 'main' into fix-1526
carlosalberto Mar 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ release.
- Define the fallback tracer name for invalid values.
([#1534](https://github.com/open-telemetry/opentelemetry-specification/pull/1534))
- Remove the Included Propagators section from trace API specification that was a duplicate of the Propagators Distribution of the context specification. ([#1556](https://github.com/open-telemetry/opentelemetry-specification/pull/1556))
- Remove the Baggage API propagator notes that conflict with the API Propagators Operations section and fix [#1526](https://github.com/open-telemetry/opentelemetry-specification/issues/1526). ([#1575](https://github.com/open-telemetry/opentelemetry-specification/pull/1575))

### Metrics

Expand Down
11 changes: 3 additions & 8 deletions specification/baggage/api.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,14 +154,9 @@ to the optional metadata.

On `extract`, the propagator should store all metadata as a single metadata instance per entry.
On `inject`, the propagator should append the metadata per the W3C specification format.

Notes:

If the propagator is unable to parse the incoming `baggage`, `extract` MUST return
a `Context` with no baggage entries in it.

If the incoming `baggage` is present, but contains no entries, `extract` MUST
return a `Context` with no baggage entries in it.
Refer to the API Propagators
[Operation](../context/api-propagators.md#operations) section for the
additional requirements these operations need to follow.

## Conflict Resolution

Expand Down