Follow up for #988. #1036
Merged
Follow up for #988. #1036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix CHANGELOG entry. - Use SHOULD for the tracestate change. - Add it to the compliance matrix.
Oberon00
reviewed
Sep 29, 2020
| @@ -101,8 +101,8 @@ It produces an output called `SamplingResult` which contains: | |||
| object must be immutable (multiple calls may return different immutable objects). | |||
| * A `Tracestate` that will be associated with the `Span` through the new | |||
| `SpanContext`. | |||
| Note: If the sampler returns an empty `Tracestate` here, the `Tracestate` will be cleared, | |||
| so samplers should normally return the passed-in `Tracestate` if they do not intend | |||
| If the sampler returns an empty `Tracestate` here, the `Tracestate` will be cleared, | |||
There was a problem hiding this comment.
But if we go that route, probably this entire section will be changed. Keeping it as a SHOULD instead of a MUST is a good situation for now ;)
Oberon00
approved these changes
Sep 29, 2020
arminru
approved these changes
Sep 29, 2020
Co-authored-by: Christian Neumüller <[email protected]>
carlosalberto
added
the
release:allowed-for-ga
|
Merging this as it's a follow up to the (important) team #988 |
carlosalberto
added a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #988
Note: Realized we need to add the list of the built-in samplers to the compliance matrix, but will do that in another PR.