-
Notifications
You must be signed in to change notification settings - Fork 897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define the list of standard exporters that SDK should support #6
Comments
I would suggest also have a simple exporter to stdout (e.g. with JSON, like a Log). |
JSON log can be used for FluentBit. We can consider defining message pack as well for telemetry types. |
I think just for JSON we should use proto to JSON, what do you think? Then we don't need to define anything for this. |
@bogdandrutu let's have it as a primary plan. I have never dealt with proto JSON and not sure if we will discover any issues with this. From the looks of it - must be straightforward |
My experience with proto JSON has been subpar:
For me, the first point re: verbose and unidiomatic JSON is the biggest concern, and should be sufficient alone to give us pause since one of the biggest values is supposed to be human readability, e.g., for use during development. |
I see a desire expressed here to support a human readable debugging log. One of the challenges there is that in the SpanData exporter model, the exporter doesn't see a span until it finishes. For debugging, I think it's pretty useful to see a log message when the span starts, and to see Span Events logged as they happen. To help demonstrate how we can achieve this outcome without sacrificing the other kinds of exporter, I put together a Golang prototype that supports observing events as they happen, without buffering, with the intention that higher-level exporters could be defined in terms of a lower-level exporter. open-telemetry/opentelemetry-go#4 I also agree with @iredelmeier that the Protobuf-to-JSON support in Google's protobuf makes for human-unreadable JSON, mainly because of |
Based on previous discussion [1] this PR adds a recommendation to include exporters for several open-source protocols in language libraries. Addresses issue open-telemetry#6 [1] - open-telemetry#277 (comment)
* Add list of exporters that are recommended for SDK Based on previous discussion [1] this PR adds a recommendation to include exporters for several open-source protocols in language libraries. Addresses issue #6 [1] - #277 (comment) * PR fixes
* Add list of exporters that are recommended for SDK Based on previous discussion [1] this PR adds a recommendation to include exporters for several open-source protocols in language libraries. Addresses issue open-telemetry#6 [1] - open-telemetry#277 (comment) * PR fixes
Second pass on specification
Proposal for trace:
Proposal for metrics:
Another question is, do we want to have these standard exporters in the SDK artifact/package?
The text was updated successfully, but these errors were encountered: