Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate specification of "Named" interfaces #587

Closed
jmacd opened this issue May 6, 2020 · 4 comments
Closed

Separate specification of "Named" interfaces #587

jmacd opened this issue May 6, 2020 · 4 comments
Labels
area:sdk Related to the SDK release:after-ga Not required before GA release, and not going to work on before GA spec:metrics Related to the specification/metrics directory spec:trace Related to the specification/trace directory

Comments

@jmacd
Copy link
Contributor

jmacd commented May 6, 2020

The specification for Named Tracers is identical to the specification for Named Meters. The text specifying Named Tracers is in the Tracer specification, but should be split out so that it can be easily referred to from the Meter specification.

Separate https://github.com/open-telemetry/opentelemetry-specification/blob/master/specification/trace/api.md#obtaining-a-tracer
@jmacd jmacd added the spec:metrics Related to the specification/metrics directory label May 6, 2020
@jmacd
Copy link
Contributor Author

jmacd commented May 6, 2020

The original comment: https://github.com/open-telemetry/opentelemetry-specification/pull/581/files/1b9d8a262ca8061646fbc635adf0b95857375d5f#r420302098

@jmacd jmacd mentioned this issue May 6, 2020
Merged
This was referenced May 19, 2020
Closed
Merged
@jmacd jmacd mentioned this issue Jun 10, 2020
Merged
@reyang reyang added area:sdk Related to the SDK spec:trace Related to the specification/trace directory labels Jun 26, 2020
@carlosalberto carlosalberto added the release:required-for-ga Must be resolved before GA release, or nice to have before GA label Jul 7, 2020
@andrewhsu andrewhsu added the priority:p3 Lowest priority level label Jul 17, 2020
@arminru arminru mentioned this issue Aug 25, 2020
Open
@tigrannajaryan
Copy link
Member

This appears to ask for an improvement in the spec structure but does not change the semantics. I suggest to remove the release:required-for-ga label.

@jmacd jmacd removed the release:required-for-ga Must be resolved before GA release, or nice to have before GA label Sep 8, 2020
@jmacd jmacd closed this as completed Sep 9, 2020
@Oberon00
Copy link
Member

Oberon00 commented Sep 9, 2020

@jmacd I'd vote for keeping this open but addressing it after GA. It does seem like a nice-to-have improvement.

@Oberon00 Oberon00 added release:after-ga Not required before GA release, and not going to work on before GA and removed priority:p3 Lowest priority level labels Sep 9, 2020
@jmacd jmacd reopened this Sep 9, 2020
@reyang
Copy link
Member

reyang commented Nov 7, 2021

Given we've now mentioned covered meter and tracer in separate docs, I think we can close this issue.

@reyang reyang closed this as completed Nov 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:sdk Related to the SDK release:after-ga Not required before GA release, and not going to work on before GA spec:metrics Related to the specification/metrics directory spec:trace Related to the specification/trace directory
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@andrewhsu @carlosalberto @Oberon00 @jmacd @tigrannajaryan @reyang