Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metrics API specification: incorporate old content on calling conventions, label sets. #601

Merged
merged 15 commits into from
May 21, 2020
Merged

Metrics API specification: incorporate old content on calling conventions, label sets. #601

merged 15 commits into from
May 21, 2020
+401 −31

Conversation

jmacd
Copy link
Contributor

@jmacd jmacd commented May 13, 2020 •
edited
Loading

Removes all the TODOs in this document.

Resolves #598
Resolves #549

This mostly incorporates content from the former api-user.md.

@jmacd jmacd added the spec:metrics Related to the specification/metrics directory label May 13, 2020
MrAlias
MrAlias approved these changes May 13, 2020
View reviewed changes
specification/metrics/api.md Outdated Show resolved Hide resolved
specification/metrics/api.md Outdated Show resolved Hide resolved
specification/metrics/api.md Outdated Show resolved Hide resolved
specification/metrics/api.md Outdated Show resolved Hide resolved
specification/metrics/api.md Outdated Show resolved Hide resolved
specification/metrics/api.md Outdated Show resolved Hide resolved
specification/metrics/api.md Outdated Show resolved Hide resolved
bogdandrutu
bogdandrutu reviewed May 19, 2020
View reviewed changes
specification/metrics/api.md Outdated Show resolved Hide resolved
specification/metrics/api.md Outdated Show resolved Hide resolved
specification/metrics/api.md Outdated Show resolved Hide resolved
specification/metrics/api.md Outdated Show resolved Hide resolved
specification/metrics/api.md Show resolved Hide resolved
specification/metrics/api.md Show resolved Hide resolved
specification/metrics/api.md Outdated Show resolved Hide resolved
specification/metrics/api.md Outdated Show resolved Hide resolved
specification/metrics/api.md Outdated Show resolved Hide resolved
specification/metrics/api.md Outdated Show resolved Hide resolved
@jmacd jmacd mentioned this pull request May 19, 2020
Closed
@jmacd jmacd mentioned this pull request May 20, 2020
Closed
jkwatson
jkwatson approved these changes May 20, 2020
View reviewed changes
Copy link
Contributor

@jkwatson jkwatson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

cijothomas
cijothomas approved these changes May 20, 2020
View reviewed changes
Copy link
Member

@cijothomas cijothomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - Looks good.
I left small non-blocking questions/comments.

carlosalberto
carlosalberto approved these changes May 21, 2020
View reviewed changes
Copy link
Contributor

@carlosalberto carlosalberto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving as a non-metric approver to get things rolling.

@bogdandrutu
Copy link
Member

@jmacd waiting on you to fix the last round of comments from @cijothomas before I merge.

@jmacd
Copy link
Contributor Author

jmacd commented May 21, 2020

I've addressed all the feedback. Thanks, reviewers!

cijothomas
cijothomas approved these changes May 21, 2020
View reviewed changes
Copy link
Member

@cijothomas cijothomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. My concerns/questions were addressed.
Happy to follow up separately on the question if UnBind() should be part of public API or not.

@bogdandrutu bogdandrutu merged commit 5b78ee1 into open-telemetry:master May 21, 2020
@bogdandrutu
Copy link
Member

@cijothomas please file an issue for that

@aabmass aabmass mentioned this pull request Apr 20, 2023
Closed
carlosalberto pushed a commit to carlosalberto/opentelemetry-specification that referenced this pull request Oct 31, 2024
@jmacd
Metrics API specification: incorporate old content on calling convent…
4210383 
…ions, label sets. (open-telemetry#601)

* Add sections on MetricProvider and obtaining a Meter

* Add sections on Naming requirements and instrument constructors

* Calling conventions, remove TODOs

* Update TOC

* Reindent sets of labels

* Reindent end matter

* Whitespace

* Feedback

* feedback on Bogdan's review

* Spelling

* MetricProvider->MeterProvider

* feedback on jkwatson's review

* Whitespace lint

* respond to cijo's comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lzchen lzchen lzchen approved these changes

@MrAlias MrAlias MrAlias approved these changes

@cijothomas cijothomas cijothomas approved these changes

@bogdandrutu bogdandrutu bogdandrutu approved these changes

@jkwatson jkwatson jkwatson approved these changes

@carlosalberto carlosalberto carlosalberto approved these changes

@arminru arminru Awaiting requested review from arminru

@c24t c24t Awaiting requested review from c24t

@iredelmeier iredelmeier Awaiting requested review from iredelmeier

@reyang reyang Awaiting requested review from reyang

@SergeyKanzhelev SergeyKanzhelev Awaiting requested review from SergeyKanzhelev

@tedsuo tedsuo Awaiting requested review from tedsuo

@tigrannajaryan tigrannajaryan Awaiting requested review from tigrannajaryan

@yurishkuro yurishkuro Awaiting requested review from yurishkuro

Assignees
No one assigned
Labels
spec:metrics Related to the specification/metrics directory
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Complete the metrics/api.md TODOs Allow one observer to observe multiple metrics
7 participants
@jmacd @bogdandrutu @carlosalberto @jkwatson @cijothomas @MrAlias @lzchen