Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Questions WRT naming inconsistency between spec and SIG #480

Closed
dyladan opened this issue Feb 19, 2020 · 3 comments
Closed

Questions WRT naming inconsistency between spec and SIG #480

dyladan opened this issue Feb 19, 2020 · 3 comments
Labels
area:api Cross language API specification issue question Question for discussion

Comments

@dyladan
Copy link
Member

dyladan commented Feb 19, 2020

We have two open issues in JS open-telemetry/opentelemetry-js#795 and open-telemetry/opentelemetry-js#794 which deal with renaming things we already had names for in order to make them use the same names as the spec. In general, is this required/encouraged by spec or should we just keep the names we already have?

@arminru
Copy link
Member

arminru commented Feb 20, 2020

I think it makes sense to have the names aligned across languages and with the spec since this makes it easier for people who use multiple languages or want to read up on the concepts in the spec.

We are currently fixing deviations in otel-java, for example: open-telemetry/opentelemetry-java#794

@thisthat
Copy link
Member

Java issue for the consistency check: open-telemetry/opentelemetry-java#794

@carlosalberto carlosalberto added question Question for discussion area:api Cross language API specification issue labels Jun 30, 2020
@reyang
Copy link
Member

reyang commented Jul 10, 2020

I think we should align with the spec as much as possible. The only exception is when the name wouldn't make sense for a particular language (e.g. conflict with a reserved keyword, would introduce big confusion as the name already established a different meaning).

@reyang reyang closed this as completed Jul 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:api Cross language API specification issue question Question for discussion
Projects
None yet
Development

No branches or pull requests

5 participants