Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Scope to Context #794

Closed
dyladan opened this issue Feb 19, 2020 · 3 comments · Fixed by #853
Closed

Rename Scope to Context #794

dyladan opened this issue Feb 19, 2020 · 3 comments · Fixed by #853
Assignees
@dyladan
Labels
Discussion Issue or PR that needs/is extended discussion.
Milestone
Beta

Comments

@dyladan
Copy link
Member

dyladan commented Feb 19, 2020

Currently we have the ScopeManager interface and various packages/classes that use the scope name. The recent introduction of the Context into the specification as well as the Context API PR #792 make me think we might be better off renaming scope to context now before we reach beta stability.
@dyladan dyladan added the Discussion Issue or PR that needs/is extended discussion. label Feb 19, 2020
@dyladan dyladan added this to the Beta milestone Feb 19, 2020
@dyladan dyladan mentioned this issue Feb 19, 2020
Closed
@dyladan
Copy link
Member Author

dyladan commented Feb 20, 2020

In open-telemetry/opentelemetry-specification#480, they seemed to think it is better to have naming aligned. Java is apparently also renaming some things to be closer to spec wording.

@vmarchaud
Copy link
Member

Digged to find why we used Scope instead of Context, coming from there: #66 (comment). Since we will have a single concept from now on i believe it's fine to rename them.

@dyladan dyladan self-assigned this Feb 20, 2020
@dyladan
Copy link
Member Author

dyladan commented Mar 3, 2020

@open-telemetry/javascript-approvers are we in favor of changing scope to context? If we wait until after beta it is likely too late.

@dyladan dyladan mentioned this issue Mar 12, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dyladan dyladan

Labels
Discussion Issue or PR that needs/is extended discussion.
Projects
None yet
Milestone
Beta
Development

Successfully merging a pull request may close this issue.

Rename scope to context dynatrace-oss-contrib/opentelemetry-js
2 participants
@dyladan @vmarchaud