Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add end to end usage example for file configuration #3465

Closed
jack-berg opened this issue May 2, 2023 · 2 comments · Fixed by #4018
Closed

Add end to end usage example for file configuration #3465

jack-berg opened this issue May 2, 2023 · 2 comments · Fixed by #4018
Assignees
@jack-berg
Labels
area:configuration Related to configuring the SDK help wanted Extra attention is needed [label deprecated] triaged-accepted [label deprecated] Issue triaged and accepted by OTel community, can proceed with creating a PR

Comments

@jack-berg
Copy link
Member

jack-berg commented May 2, 2023 •
edited
Loading

We should add end to end usage examples to the file configuration document to make it clear how the APIs are intended to be used.

Would an example in this section be appropriate? It might help make it more clear how a Configurer would be instantiated and used

Originally posted by @codeboten in #3437 (comment)
@jack-berg jack-berg mentioned this issue May 2, 2023
Merged
@tigrannajaryan tigrannajaryan added area:configuration Related to configuring the SDK [label deprecated] triaged-accepted [label deprecated] Issue triaged and accepted by OTel community, can proceed with creating a PR help wanted Extra attention is needed labels Nov 1, 2023
@tigrannajaryan
Copy link
Member

@jack-berg do you plan to work on this or we need help?

@jack-berg
Copy link
Member Author

I plan on working on it. I've assigned myself.

@jack-berg jack-berg self-assigned this Nov 1, 2023
@jack-berg jack-berg mentioned this issue Apr 26, 2024
Merged
jack-berg added a commit that referenced this issue May 1, 2024
@jack-berg @reyang
Add file configuration examples (#4018)
6360b49 
Resolves #3465

---------

Co-authored-by: Reiley Yang <[email protected]>
carlosalberto pushed a commit to carlosalberto/opentelemetry-specification that referenced this issue Oct 31, 2024
@jack-berg @reyang
Add file configuration examples (open-telemetry#4018)
1177378 
Resolves open-telemetry#3465

---------

Co-authored-by: Reiley Yang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jack-berg jack-berg

Labels
area:configuration Related to configuring the SDK help wanted Extra attention is needed [label deprecated] triaged-accepted [label deprecated] Issue triaged and accepted by OTel community, can proceed with creating a PR
Projects
Declarative Configuration Stability
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add file configuration examples jack-berg/opentelemetry-specification
3 participants
@carlosalberto @tigrannajaryan @jack-berg