-
Notifications
You must be signed in to change notification settings - Fork 898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Confirming it's ok to mark HTTP semconv stable without marking net.*
attributes stable
#3260
Labels
Comments
I think we should at least split out a part of the net conventions needed for HTTP and mark it as stable (if we don't want to mark them as stable completely). Otherwise it becomes a bit too subtle. |
Discussed in the spec meeting and there is desire to at least mark attributes in span general that are used by stable HTTP semantic conventions, so it's clear that the changes allowed to them are limited. |
tigrannajaryan
added a commit
that referenced
this issue
Apr 6, 2023
) Fixes #3260 (a first try at least) ## Changes Splits `net.*` attributes into two sections, and adds this warning to the attributes in the first section: > **Warning** Most of the attributes in this section are in use by the HTTP semantic conventions. Once the HTTP semantic conventions are declared stable, changes to the attributes in this section will only be allowed if they do not cause breaking changes to HTTP semantic conventions. Co-authored-by: Liudmila Molkova <[email protected]> Co-authored-by: Carlos Alberto Cortez <[email protected]> Co-authored-by: Tigran Najaryan <[email protected]>
carlosalberto
added a commit
to carlosalberto/opentelemetry-specification
that referenced
this issue
Oct 31, 2024
…en-telemetry#3278) Fixes open-telemetry#3260 (a first try at least) ## Changes Splits `net.*` attributes into two sections, and adds this warning to the attributes in the first section: > **Warning** Most of the attributes in this section are in use by the HTTP semantic conventions. Once the HTTP semantic conventions are declared stable, changes to the attributes in this section will only be allowed if they do not cause breaking changes to HTTP semantic conventions. Co-authored-by: Liudmila Molkova <[email protected]> Co-authored-by: Carlos Alberto Cortez <[email protected]> Co-authored-by: Tigran Najaryan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The HTTP semconv stability working group believes that it's ok to mark HTTP semconv as stable without marking any part of span general semconv as stable.
But we would like to make sure that there's broader community agreement on this point and discuss if there is any disagreement.
What we believe is that by marking HTTP semconv as stable, we will be marking the
net.*
attributes that are used in the HTTP semconv as stable within the context of HTTP semantic conventions, with the HTTP-specific definitions of them which appear in the HTTP semconv.This will inherently place a barrier to changing these attribute names in the span general semconv, but at the same time it leaves some flexibility in the precise definition of these attributes at the more abstract/general
net.*
level.The text was updated successfully, but these errors were encountered: