Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

semantic_convention: remoting client attributes #26

Closed
SergeyKanzhelev opened this issue May 24, 2019 · 8 comments
Closed

semantic_convention: remoting client attributes #26

SergeyKanzhelev opened this issue May 24, 2019 · 8 comments
Labels
area:semantic-conventions Related to semantic conventions
Milestone

Comments

@SergeyKanzhelev
Copy link
Member

No description provided.

@SergeyKanzhelev SergeyKanzhelev changed the title semantic_convention: remoting attributes semantic_convention: remoting clinet attributes May 24, 2019
@SergeyKanzhelev SergeyKanzhelev changed the title semantic_convention: remoting clinet attributes semantic_convention: remoting client attributes May 24, 2019
@SergeyKanzhelev SergeyKanzhelev added this to the SDK complete milestone Jun 3, 2019
@SergeyKanzhelev SergeyKanzhelev added area:sdk Related to the SDK area:semantic-conventions Related to semantic conventions and removed area:sdk Related to the SDK labels Jun 21, 2019
@SergeyKanzhelev SergeyKanzhelev removed this from the SDK proposal complete milestone Jun 21, 2019
@SergeyKanzhelev SergeyKanzhelev added this to the Alpha v0.3 milestone Sep 27, 2019
@Oberon00
Copy link
Member

Oberon00 commented Oct 1, 2019

I guress "remoting" refers to RPC/RMI here?

@Oberon00
Copy link
Member

Oberon00 commented Oct 1, 2019

Related: #27

@SergeyKanzhelev
Copy link
Member Author

@Oberon00 yes. This is from the excel spreadshit that @danielkhan shared before

@jmacd
Copy link
Contributor

jmacd commented Dec 4, 2019

Closing this as stale, probably addressed in #349

@jmacd jmacd closed this as completed Dec 4, 2019
@Oberon00
Copy link
Member

Oberon00 commented Dec 5, 2019

Even though the networking attributes added in #349 are certainly useful for remoting, I don't think they cover everything. E.g. I'd assume there should be attributes for the service and method name.

@arminru
Copy link
Member

arminru commented Dec 11, 2019

@SergeyKanzhelev @jmacd
I agree with @Oberon00 that this should be reopened and addressed. It would make sense to add the RPC method and flavor/system to the semantic conventions. As of now the conventions also only specify/allow gRPC.

@jmacd
Copy link
Contributor

jmacd commented Jan 29, 2020

I believe this was fixed by #349 and #386.

@jmacd jmacd closed this as completed Jan 29, 2020
@jmacd jmacd modified the milestones: Alpha v0.3, Alpha v0.4 Jan 29, 2020
@Oberon00
Copy link
Member

I think the last comment by @arminru still applies, we only have conventions for the very narrow special case of grpc. But probably this issue could be tracked with #27, if we give that one a better name.

@bogdandrutu bogdandrutu modified the milestones: v0.5, v0.4 May 12, 2020
TuckTuckFloof pushed a commit to TuckTuckFloof/opentelemetry-specification that referenced this issue Oct 15, 2020
carlosalberto pushed a commit to carlosalberto/opentelemetry-specification that referenced this issue Oct 21, 2024
…n-telemetry#26)

* Propose: Remove support to report out-of-band telemetry from the API

* Clarify what the change means

* Update text/0007-no-out-of-band-reporting.md

Co-Authored-By: Yang Song <[email protected]>

* Update text/0007-no-out-of-band-reporting.md

Co-Authored-By: Yang Song <[email protected]>
carlosalberto pushed a commit to carlosalberto/opentelemetry-specification that referenced this issue Oct 23, 2024
…n-telemetry#26)

* Propose: Remove support to report out-of-band telemetry from the API

* Clarify what the change means

* Update text/0007-no-out-of-band-reporting.md

Co-Authored-By: Yang Song <[email protected]>

* Update text/0007-no-out-of-band-reporting.md

Co-Authored-By: Yang Song <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:semantic-conventions Related to semantic conventions
Projects
None yet
Development

No branches or pull requests

5 participants