Skip to content

Commit

Permalink
Address PR comments
Browse files Browse the repository at this point in the history
  • Loading branch information
Tigran Najaryan committed Aug 14, 2020
1 parent 276a395 commit e8e6066
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions specification/common/common.md
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ Attribute names SHOULD follow these rules:
words by underscores (i.e. use snake_case). For example `http.status_code`
denotes the status code in the http namespace.

- Attribute names should not coincide with namespaces. For example if
- Attribute names SHOULD NOT coincide with namespaces. For example if
`service.instance.id` is an attribute name then it is no longer valid to have
an attribute named `service.instance` because `service.instance` is already a
namespace. Because of this rule be careful when choosing attribute names:
Expand All @@ -66,7 +66,7 @@ Attribute names SHOULD follow these rules:

#### Recommendations for OpenTelemetry Authors

- All attributes names that are part of OpenTelemetry semantic conventions
- All attribute names that are part of OpenTelemetry semantic conventions
SHOULD be part of a namespace.

- When coming up with a new convention make sure to check existing namespaces
Expand Down

0 comments on commit e8e6066

Please sign in to comment.