-
Notifications
You must be signed in to change notification settings - Fork 891
Commit
- Loading branch information
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -323,6 +323,10 @@ The Span interface MUST provide: | |
as arguments. This MAY be called `SetAttribute`. To avoid extra allocations some | ||
implementations may offer a separate API for each of the possible value types. | ||
|
||
Attributes SHOULD preserve the order in which they're set. Setting an attribute | ||
with the same key as an existing attribute SHOULD overwrite the existing | ||
attribute's value, but not affect its ordering. | ||
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
c24t
Author
Member
|
||
|
||
Note that the OpenTelemetry project documents certain ["standard | ||
attributes"](../semantic-conventions.md) that have prescribed semantic meanings. | ||
|
||
|
@@ -345,6 +349,9 @@ by providing an `Event` interface or a concrete `Event` definition and an | |
`EventFormatter`. If the language supports overloads then this SHOULD be called | ||
`AddEvent` otherwise `AddLazyEvent` may be considered. | ||
|
||
Events SHOULD preserve the order in which they're set. This will typically match | ||
the ordering of the events' timestamps. | ||
|
||
Note that the OpenTelemetry project documents certain ["standard event names and | ||
keys"](../semantic-conventions.md) which have prescribed semantic meanings. | ||
|
||
|
@@ -368,6 +375,8 @@ by providing a `Link` interface or a concrete `Link` definition and a | |
`LinkFormatter`. If the language supports overloads then this MAY be called | ||
`AddLink` otherwise `AddLazyLink` MAY be consider. | ||
|
||
Links SHOULD preserve the order in which they're set. | ||
|
||
#### Set Status | ||
|
||
Sets the [`Status`](#status) of the `Span`. If used, this will override the | ||
|
Hmm, this is different from the Python SDK PR, which affects the ordering (by promoting the key to the newest). Which one is the intended behavior?