Skip to content

Commit

Permalink
remove rntbd
Browse files Browse the repository at this point in the history
  • Loading branch information
sourabh1007 committed Jan 31, 2023
1 parent 647bcee commit 73f2283
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 44 deletions.
24 changes: 0 additions & 24 deletions semantic_conventions/trace/database.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -460,30 +460,6 @@ groups:
examples: [46.18, 1.0]
requirement_level:
conditionally_required: when available

- id: rntbd
type: span
prefix: rntbd
brief: Describes Network calls to CosmosDB in Direct mode. When used in HTTP mode, follow HTTP semantic conventions.
note: I'd remove it from this document and address in a different PR - this describes protocol semantic conventions.
attributes:
- id: resource_type
type: string
brief: Resource Tyoe
examples: ['Document']
- id: url
type: string
tag: connection-level
brief: Cosmos DB request URL
examples: 'rntb://<hostname><partitionid><replicaid>'
- id: status_code
type: string
brief: status code
examples: [1000, 1002]
- id: sub_status_code
type: string
brief: sub status code
examples: ['0']

- id: db.tech
type: span
Expand Down
20 changes: 0 additions & 20 deletions specification/trace/semantic_conventions/database.md
Original file line number Diff line number Diff line change
Expand Up @@ -239,14 +239,6 @@ Cosmos DB instrumentation includes call-level (public API) surface spans and net
|---|---|
| `gateway` | Gateway (HTTP) connections mode |
| `direct` | Direct connection. |

| Attribute | Type | Description | Examples | Requirement Level |
|---|---|---|---|---|
| `rntbd.resource_type` | string | Cosmosdb Resource Type | Document | Required |
| `rntbd.url` | string | RNTBD URL | rntbd://host:port/partitionid/replicaId | Required |
| `rntbd.status_code` | int | Status Code | 200 | Required |
| `rntbd.sub_status_code` | int | Sub Status Code | 1000 | Conditionally Required: When there is an exception |

<!-- endsemconv -->

In addition to Cosmos DB attributes, all spans include
Expand Down Expand Up @@ -326,15 +318,3 @@ Furthermore, `db.name` is not specified as there is no database name in Redis an
| `db.cosmosdb.status_code` | `201` |
| `db.cosmosdb.sub_status_code` | `0` |
| `db.cosmosdb.request_charge` | `7.43` |


| Key | Value |
| :-------- | :------------------- |
| Span name | `"Request.Read"` |
| `kind` | `"client"` |
| `az.namespace` | `"Microsoft.DocumentDB"` |
| `db.system` | `"cosmosdb"` |
| `rntbd.resource_type` | `"Document"` |
| `rntbd.url` | `"rntbd://<hostname><partitionid><replicaid>"` |
| `rntbd.status_code` | `201` |
| `rntbd.sub_status_code` | `0` |

0 comments on commit 73f2283

Please sign in to comment.