Skip to content

Commit

Permalink
linting
Browse files Browse the repository at this point in the history
Signed-off-by: Giovanni Liva <[email protected]>
  • Loading branch information
thisthat committed Feb 27, 2023
1 parent 00e40c7 commit 349be5a
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 6 deletions.
1 change: 0 additions & 1 deletion semantic_conventions/logs/log-deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -34,4 +34,3 @@ groups:
requirement_level: recommended
- ref: deployment.task.name
- ref: deployment.task.status

2 changes: 1 addition & 1 deletion semantic_conventions/trace/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ groups:
brief: 'The deployment was **not** completed correctly'
- id: 'unknown'
value: 'Unknown'
brief: 'The deployment wass unsuccessful and the reason is unknown'
brief: 'The deployment was unsuccessful and the reason is unknown'
brief: >
The status of the workload deployment.
Expand Down
1 change: 0 additions & 1 deletion specification/logs/semantic_conventions/deployment.md
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,6 @@ Task executions that support deployments SHOULD be recorded as attributes on the
operations. Task executions MAY be recorded on "logs" or "events" depending on the
context.


### Attributes

<!-- semconv log-deployment-task -->
Expand Down
6 changes: 3 additions & 3 deletions specification/trace/semantic_conventions/deployment.md
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ deployment of an application.

### Application

Each stage of the lifecycle of a cloud-native application deployment SHOULD be recorded as an Event on the span during
Each stage of the lifecycle of a cloud-native application deployment SHOULD be recorded as an Event on the span during
which it occurred.

<!-- semconv deployment.application -->
Expand All @@ -54,7 +54,7 @@ The event name MUST be `deployment.application`.
| `Unknown` | The deployment was unsuccessful and the reason is unknown |
<!-- endsemconv -->

### Workload
### Workload

Cloud-native applications are composed of one or several components that are usually called [workloads](https://kubernetes.io/docs/concepts/workloads/).
Similarly to applications, each stage of the lifecycle of a workload deployment SHOULD be recorded as an Event on the span during
Expand All @@ -79,7 +79,7 @@ The event name MUST be `deployment.workload`.
| `Progressing` | The deployment is currently taking place |
| `Succeeded` | The deployment was completed correctly |
| `Failed` | The deployment was **not** completed correctly |
| `Unknown` | The deployment wass unsuccessful and the reason is unknown |
| `Unknown` | The deployment was unsuccessful and the reason is unknown |
<!-- endsemconv -->

### Task
Expand Down

0 comments on commit 349be5a

Please sign in to comment.