Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(exmaples): actix web should use TokioCurrentThread as runtime #734

Merged
merged 4 commits into from
Feb 14, 2022

Conversation

TommyCpp
Copy link
Contributor

@TommyCpp TommyCpp commented Feb 13, 2022

small changes to address an issue in examples.

@TommyCpp TommyCpp requested a review from a team February 13, 2022 21:04
@codecov
Copy link

codecov bot commented Feb 13, 2022

Codecov Report

Merging #734 (a69879f) into main (b695ba1) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #734      +/-   ##
==========================================
- Coverage   71.50%   71.48%   -0.02%     
==========================================
  Files         102      102              
  Lines        8593     8593              
==========================================
- Hits         6144     6143       -1     
- Misses       2449     2450       +1     
Impacted Files Coverage Δ
opentelemetry/src/sdk/metrics/controllers/push.rs 80.00% <0.00%> (-3.34%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b695ba1...a69879f. Read the comment docs.

@djc
Copy link
Contributor

djc commented Feb 14, 2022

It would be useful if there was a bit more context in the comments and/or commit message about why this example should use the current thread runtime.

@TommyCpp TommyCpp merged commit ed71d80 into open-telemetry:main Feb 14, 2022
@TommyCpp
Copy link
Contributor Author

It would be useful if there was a bit more context in the comments and/or commit message about why this example should use the current thread runtime.

Sorry I somehow missed this before merging 😞 . I will add some comments in the example to explain this. But in general actix web is running on tokio single thread scheduler so the runtime has to be TokioCurrentThread

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants