Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint: fix issues with unnecessary wraps #456

Merged
merged 2 commits into from
Feb 14, 2021

Conversation

ozerovandrei
Copy link
Contributor

Remove Result from return types in tests of opentelemetry-datadog,
opentelemetry-jaeger, opentelemetry-otlp, opentelemetry-zipkin.

Reference: rust-lang/rust-clippy#6070

Remove `Result` from return types in tests of `opentelemetry-datadog`,
`opentelemetry-jaeger`, `opentelemetry-otlp`, `opentelemetry-zipkin`.

Reference: rust-lang/rust-clippy#6070
@codecov
Copy link

codecov bot commented Feb 14, 2021

Codecov Report

❗ No coverage uploaded for pull request base (main@238e797). Click here to learn what that means.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #456   +/-   ##
=======================================
  Coverage        ?   47.88%           
=======================================
  Files           ?       95           
  Lines           ?     8736           
  Branches        ?        0           
=======================================
  Hits            ?     4183           
  Misses          ?     4553           
  Partials        ?        0           
Impacted Files Coverage Δ
opentelemetry-datadog/src/exporter/mod.rs 14.45% <100.00%> (ø)
opentelemetry-jaeger/src/exporter/mod.rs 40.31% <100.00%> (ø)
opentelemetry-zipkin/src/exporter/model/span.rs 94.25% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 238e797...11d75a4. Read the comment docs.

Copy link
Member

@jtescher jtescher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks

@jtescher jtescher merged commit f79586b into open-telemetry:main Feb 14, 2021
@ozerovandrei ozerovandrei deleted the fix-lint-issues branch February 14, 2021 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants