-
Notifications
You must be signed in to change notification settings - Fork 451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zipkin - exclude status code if unset #382
Conversation
Codecov Report
@@ Coverage Diff @@
## master #382 +/- ##
=======================================
Coverage 49.34% 49.34%
=======================================
Files 66 66
Lines 5326 5326
=======================================
Hits 2628 2628
Misses 2698 2698 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be nice to indicate the UNSET
should never be used here.
opentelemetry-rust/opentelemetry-zipkin/src/exporter/model/mod.rs
Lines 38 to 44 in d157ecf
fn from_statuscode_to_str(status_code: StatusCode) -> &'static str { | |
match status_code { | |
StatusCode::Ok => "OK", | |
StatusCode::Unset => "UNSET", | |
StatusCode::Error => "ERROR", | |
} | |
} |
d157ecf
to
3a3b52d
Compare
I had intentionally left that with the thinking that the function might be useful in future if there was a need for a stringified version of the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
Fixes #355