Return span context ref #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the `Span` trait in the API has its `span_context` method return an owned `SpanContext`. In order to be more consistent with the rest of the APIs, this patch updates the trait to instead return a reference, and moves the `SpanContext` data outside of the mutex in the SDK to implement the trait. This also allows #265 to be implemented without having to lock. Additionally the spec now states that the `on_start` method for `SpanProcessor`s must be passed a span and the parent context so those are updated as well.
Codecov Report
@@ Coverage Diff @@
## master #325 +/- ##
==========================================
- Coverage 53.42% 53.37% -0.05%
==========================================
Files 71 71
Lines 5758 5778 +20
==========================================
+ Hits 3076 3084 +8
- Misses 2682 2694 +12
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the
Spantrait in the API has itsspan_contextmethod return an ownedSpanContext. In order to be more consistent with the rest of the APIs, this patch updates the trait to instead return a reference, and moves theSpanContextdata outside of the mutex in the SDK to implement the trait. This also allows #265 to be implementedwithout having to lock.
Additionally the spec now states that the
on_startmethod forSpanProcessors must be passed a span and the parent context so those are updated as well.