Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove support for u64 and bytes values (see #317) #323

Merged
merged 1 commit into from
Oct 31, 2020
Merged

Remove support for u64 and bytes values (see #317) #323

merged 1 commit into from
Oct 31, 2020

Conversation

djc
Copy link
Contributor

@djc djc commented Oct 31, 2020

The current spec does not recognize these types.

@djc djc requested a review from a team October 31, 2020 11:46
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 31, 2020 •
edited
Loading

CLA Check
The committers are authorized under a signed CLA.

@djc djc force-pushed the rm-u64-bytes branch 3 times, most recently from a5102a4 to 388dea4 Compare October 31, 2020 12:28
frigus02
frigus02 reviewed Oct 31, 2020
View reviewed changes
Copy link
Member

@frigus02 frigus02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this. Changes look good to me. I do have one concern about the array formatting, though.

src/api/core.rs Outdated Show resolved Hide resolved
@jtescher jtescher merged commit be76c0a into open-telemetry:master Oct 31, 2020
@djc djc mentioned this pull request Nov 3, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frigus02 frigus02 frigus02 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@djc @frigus02 @jtescher