Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic tests for SDK Span #309

Merged
merged 3 commits into from
Oct 27, 2020

Conversation

morigs
Copy link
Contributor

@morigs morigs commented Oct 26, 2020

This PR adds tests for Span implementation.
The purpose of these changes is to make it easier to make changes and ensure compliance with the specification.
Please let me know if some tests are unnecessary or some are missing

@morigs morigs requested a review from a team October 26, 2020 17:27
Copy link
Member

@jtescher jtescher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @morigs

@jtescher jtescher merged commit f99535d into open-telemetry:master Oct 27, 2020
@morigs morigs deleted the feature/span-tests branch October 27, 2020 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants