Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update msrv version to 1.65 in docs #1770

Merged
merged 2 commits into from
May 15, 2024

Conversation

lalitb
Copy link
Member

@lalitb lalitb commented May 15, 2024

Changes

While we bumped msrv to 1.65 in #1318, the docs are still showing 1.64. Updating it.
Not updating changelog, as this is just the doc update.

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@lalitb lalitb requested a review from a team May 15, 2024 01:14
@lalitb lalitb changed the title Update msrv version to1.65 in docs Update msrv version to 1.65 in docs May 15, 2024
Copy link

codecov bot commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.6%. Comparing base (348ec9e) to head (eaced7f).
Report is 34 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #1770     +/-   ##
=======================================
+ Coverage   71.0%   71.6%   +0.5%     
=======================================
  Files        135     136      +1     
  Lines      20751   20846     +95     
=======================================
+ Hits       14746   14935    +189     
+ Misses      6005    5911     -94     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@cijothomas cijothomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Maybe we should find a way to store it in one place only and have it referred elsewhere.

@lalitb
Copy link
Member Author

lalitb commented May 15, 2024

Thanks. Maybe we should find a way to store it in one place only and have it referred elsewhere.

Yes, same thoughts. Will do it next time :)

@cijothomas cijothomas merged commit 6d7a16c into open-telemetry:main May 15, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants