Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Batch LogRecord&Span Processor configuration via non-standard environment variables #1495

Merged

Conversation

CosminLazar
Copy link
Contributor

@CosminLazar CosminLazar commented Jan 25, 2024

Fixes #
Design discussion issue (if applicable) #

Changes

Removes Batch LogRecord&Span Processor configuration via non-standard environment variables.

For convenience and discoverability, a mapping table from the no longer supported to the supported environment variables is provided here:

No longer supported Standard equivalent
OTEL_BLRP_SCHEDULE_DELAY_MILLIS OTEL_BLRP_SCHEDULE_DELAY
OTEL_BLRP_EXPORT_TIMEOUT_MILLIS OTEL_BLRP_EXPORT_TIMEOUT
OTEL_BSP_SCHEDULE_DELAY_MILLIS OTEL_BSP_SCHEDULE_DELAY
OTEL_BSP_EXPORT_TIMEOUT_MILLIS OTEL_BSP_EXPORT_TIMEOUT

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

Copy link

codecov bot commented Jan 25, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (27b19b6) 63.7% compared to head (2522e76) 64.0%.
Report is 1 commits behind head on main.

Files Patch % Lines
opentelemetry-sdk/src/trace/span_processor.rs 97.6% 3 Missing ⚠️
opentelemetry-sdk/src/logs/log_processor.rs 98.0% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main   #1495     +/-   ##
=======================================
+ Coverage   63.7%   64.0%   +0.2%     
=======================================
  Files        142     142             
  Lines      19499   19507      +8     
=======================================
+ Hits       12437   12499     +62     
+ Misses      7062    7008     -54     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CosminLazar
Copy link
Contributor Author

As per our discussion in #1480, I have also replaced the links to the OLTP specification with the actual supported environment variables. If bundling this change with this PR is undesirable, let me know and I will make another PR.

@CosminLazar CosminLazar marked this pull request as ready for review January 25, 2024 20:03
@CosminLazar CosminLazar requested a review from a team January 25, 2024 20:03
@cijothomas cijothomas merged commit 85f678a into open-telemetry:main Jan 25, 2024
15 checks passed
@CosminLazar CosminLazar deleted the remove-batch-non-standard-env branch January 27, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants