Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Span events stored as Vector instead of EvictedQueue #1350

Merged
merged 11 commits into from
Nov 9, 2023

Conversation

cijothomas
Copy link
Member

@cijothomas cijothomas commented Nov 7, 2023

Continuing from https://github.com/open-telemetry/opentelemetry-rust/pull/1313/files, this one for Events.

Cleanup of unused code (EvictedQueue etc. will be done later.)
IndexMap dependency is also potentially removable, after some more fixes in Loggging side. Expect them as follow ups!

Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Files Coverage Δ
opentelemetry-datadog/src/exporter/model/mod.rs 85.1% <100.0%> (-0.1%) ⬇️
opentelemetry-sdk/src/export/trace.rs 40.0% <ø> (ø)
opentelemetry-sdk/src/testing/trace/mod.rs 80.8% <100.0%> (ø)
opentelemetry-sdk/src/trace/events.rs 100.0% <100.0%> (ø)
opentelemetry-sdk/src/trace/mod.rs 100.0% <100.0%> (ø)
opentelemetry-sdk/src/trace/span.rs 96.1% <100.0%> (+0.2%) ⬆️
opentelemetry-sdk/src/trace/span_processor.rs 82.8% <100.0%> (ø)
opentelemetry-sdk/src/trace/tracer.rs 94.7% <100.0%> (+<0.1%) ⬆️
opentelemetry-zipkin/src/exporter/model/span.rs 96.1% <100.0%> (ø)
opentelemetry-jaeger/src/exporter/mod.rs 57.3% <0.0%> (ø)
... and 2 more

... and 3 files with indirect coverage changes

📢 Thoughts on this report? Let us know!

@cijothomas cijothomas marked this pull request as ready for review November 8, 2023 18:35
@cijothomas cijothomas requested a review from a team November 8, 2023 18:35
Copy link
Member

@jtescher jtescher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@jtescher jtescher merged commit d7e4629 into open-telemetry:main Nov 9, 2023
14 checks passed
@cijothomas cijothomas deleted the cijothomas/events_as_vec branch November 9, 2023 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants