-
Notifications
You must be signed in to change notification settings - Fork 452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Span links stored as Vector instead of EvictedQueue #1313
Merged
jtescher
merged 23 commits into
open-telemetry:main
from
cijothomas:cijothomas/links-as-vec
Nov 7, 2023
Merged
Span links stored as Vector instead of EvictedQueue #1313
jtescher
merged 23 commits into
open-telemetry:main
from
cijothomas:cijothomas/links-as-vec
Nov 7, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cijothomas
changed the title
Cijothomas/links as vec
Span links stored as Vector instead of EvictedQueue
Oct 20, 2023
Codecov ReportAttention:
📢 Thoughts on this report? Let us know! |
TommyCpp
approved these changes
Oct 23, 2023
shaun-cox
approved these changes
Oct 23, 2023
shaun-cox
approved these changes
Nov 1, 2023
jtescher
reviewed
Nov 1, 2023
lalitb
reviewed
Nov 6, 2023
lalitb
approved these changes
Nov 6, 2023
@jtescher could you re-review and merge if good? |
jtescher
approved these changes
Nov 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great thanks @cijothomas
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing #1293. This PR modifies Span links - they are now stored as Vec, and the limit enforcement is done without the previous "eviction" behavior. A simpler logic of keeping the 1st "N" links is performed now. Have not done more benchmarks given the perf gains are already proven in prior PRs.