Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Span links stored as Vector instead of EvictedQueue #1313

Merged
merged 23 commits into from
Nov 7, 2023

Conversation

cijothomas
Copy link
Member

@cijothomas cijothomas commented Oct 20, 2023

Continuing #1293. This PR modifies Span links - they are now stored as Vec, and the limit enforcement is done without the previous "eviction" behavior. A simpler logic of keeping the 1st "N" links is performed now. Have not done more benchmarks given the perf gains are already proven in prior PRs.

@cijothomas cijothomas requested a review from a team October 20, 2023 22:46
@cijothomas cijothomas changed the title Cijothomas/links as vec Span links stored as Vector instead of EvictedQueue Oct 20, 2023
@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Files Coverage Δ
opentelemetry-datadog/src/exporter/model/mod.rs 85.2% <100.0%> (ø)
opentelemetry-sdk/src/export/trace.rs 40.0% <ø> (ø)
opentelemetry-sdk/src/testing/trace/mod.rs 80.8% <100.0%> (ø)
opentelemetry-sdk/src/trace/links.rs 100.0% <100.0%> (ø)
opentelemetry-sdk/src/trace/mod.rs 100.0% <100.0%> (ø)
opentelemetry-sdk/src/trace/span.rs 95.8% <100.0%> (+0.2%) ⬆️
opentelemetry-sdk/src/trace/span_processor.rs 82.8% <100.0%> (ø)
opentelemetry-sdk/src/trace/tracer.rs 94.6% <100.0%> (+0.2%) ⬆️
opentelemetry-zipkin/src/exporter/model/span.rs 96.1% <100.0%> (ø)
opentelemetry-proto/src/transform/trace.rs 38.8% <50.0%> (ø)
... and 3 more

📢 Thoughts on this report? Let us know!

opentelemetry-sdk/src/trace/span.rs Outdated Show resolved Hide resolved
opentelemetry-sdk/src/trace/links.rs Show resolved Hide resolved
opentelemetry-sdk/src/trace/links.rs Show resolved Hide resolved
@cijothomas
Copy link
Member Author

@jtescher could you re-review and merge if good?

Copy link
Member

@jtescher jtescher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great thanks @cijothomas

@jtescher jtescher merged commit 4cff5c6 into open-telemetry:main Nov 7, 2023
14 checks passed
@cijothomas cijothomas deleted the cijothomas/links-as-vec branch November 7, 2023 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants