Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rust CI targets #120

Merged
merged 2 commits into from
Jun 16, 2020
Merged

Update rust CI targets #120

merged 2 commits into from
Jun 16, 2020

Conversation

jtescher
Copy link
Member

Add beta channel to test matrix and mark nightly as optional.

Add beta channel to test matrix and mark nightly as optional.
@iredelmeier
Copy link
Member

@jtescher unless it's changed since I last heard, only the technical committee are able to update check requirement :/

Thoughts on making the checks succeed, rather than skipping them, if any necessary components are unavailable?

@jtescher
Copy link
Member Author

That is what is intended in this change, the continue-on-error setup should allow nightly to fail without failing the whole workflow.

However the old checks from before are still being applied to this pr as well as the new ones and will now not run so they are stuck on expected?

@iredelmeier
Copy link
Member

Ah, I see what you mean. When I saw that the nightly checks were stuck for this PR, I figured that was because "continue-on-error" was getting misinterpreted as something other than success.

@jtescher
Copy link
Member Author

@iredelmeier the checks have been removed, want to review? 🙏

@jtescher jtescher merged commit b609ada into master Jun 16, 2020
@jtescher jtescher deleted the jtescher/update-rust-ci-targets branch June 16, 2020 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants