Fix OrderMap reference in log subsystem #1073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #1073 +/- ##
=====================================
Coverage 50.9% 50.9%
=====================================
Files 165 165
Lines 19689 19689
=====================================
Hits 10025 10025
Misses 9664 9664
☔ View full report in Codecov by Sentry. |
djc
reviewed
May 23, 2023
djc
reviewed
May 25, 2023
opentelemetry-api/src/logs/mod.rs
Outdated
| @@ -13,6 +13,9 @@ pub use logger::{Logger, LoggerProvider}; | |||
| pub use noop::NoopLoggerProvider; | |||
| pub use record::{AnyValue, LogRecord, LogRecordBuilder, Severity, TraceContext}; | |||
|
|
|||
| use std::collections::hash_map::RandomState; | |||
There was a problem hiding this comment.
I don't think this is needed anymore? Is the only remaining value of this PR sorting the imports correctly?
There was a problem hiding this comment.
Good catch. Removed the import.
TommyCpp
approved these changes
May 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Design discussion issue (if applicable) #
Changes
As part of PR #1061, the OrderMap module was moved from
copentelemetry-api::tracetoopentelemetry-apiroot. This PR ensures that log subsystem should refer to the OrderMap module fromopentelemetry-api, and not fromopentelemetry-api::trace.Also added the reexport in logs to ensure that existing usage (if any) is not broken.Please provide a brief description of the changes here.
Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial, user-facing changes