Add OTLPMetricPipeline builder methods for delta and lowmemory #1057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lzchen
reviewed
May 25, 2023
|
|
||
| ### Added | ||
| - Added builder methods to configure delta, low-memory temporality for OTLP | ||
| Metric pipeline |
lzchen
reviewed
May 25, 2023
| pub(crate) _private: (), | ||
| } | ||
|
|
||
| impl DeltaTemporalitySelector { |
There was a problem hiding this comment.
We have the same thing defined in benches currently. Is it worthwhile to consolidate this into a common place?
hdost
reviewed
May 31, 2023
| /// [Temporality::Cumulative] will be used for UpDownCounter and Asynchronous UpDownCounter | ||
| #[derive(Clone, Default, Debug)] | ||
| struct DeltaTemporalitySelector { | ||
| pub(crate) _private: (), |
jtescher
approved these changes
Jun 1, 2023
|
|
||
| impl LowMemoryTemporalitySelector { | ||
| /// Create a new default temporality selector. | ||
| fn new() -> Self { |
There was a problem hiding this comment.
nit: as the lint is pointing out, are you intending this to be pub? or should this be removed as it's not used.
hdost
requested changes
Oct 26, 2023
4 tasks
|
Closing as #1568 covered this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Add new builder methods to help build OTLP Metrics Pipeline with desired Temporality. This PR specifically adds
builders to support the "Delta" and "LowMemory" temporality preference from the spec:
https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/metrics/sdk_exporters/otlp.md#additional-configuration
Note that the env variable support for the same (OTEL_EXPORTER_OTLP_METRICS_TEMPORALITY_PREFERENCE), is not part of this PR, and will be offered as a separate PR.
Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial, user-facing changes