-
Notifications
You must be signed in to change notification settings - Fork 453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Propagators API #1013
Comments
If that were the case then these should also be in the SDK. As well the specific propagators such as Jaeger and B3(a.k.a Zipkin) should be in different extension crates and the W3C ones can (probably should by included in the API). |
https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/context/api-propagators.md#propagators-distribution From this spec, the W3C propagators may be distributed as part of API packages. |
Distribution of propagators in other language:
For composite propagator I think we should move it to API because:
For baggage propagator and trace context propagator I think we can leave them in the SDK for now. Although it's different from other languages I think it's aligned with our principle to keep the interfaces and implementations separate |
Move `TextMapCompositePropagator` from `opentelemetry-sdk` to `opentelemetry` crate. Fixes #1013
According to the spec the propagators https://github.com/open-telemetry/opentelemetry-rust/blob/main/opentelemetry-sdk/src/propagation/composite.rs should be in the API instead of the SDK
Context Conversation: https://cloud-native.slack.com/archives/C03GDP0H023/p1679426866872239
The text was updated successfully, but these errors were encountered: