-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Rack instrumentation #166
Merged
fbogsany
merged 75 commits into
open-telemetry:master
from
mutations:rack-instrumentation--67
Mar 5, 2020
Merged
Changes from 1 commit
Commits
Show all changes
75 commits
Select commit
Hold shift + click to select a range
508b8df
rack: Add Gemfile, gemspec, version
duonoid 367c78c
Add Rakefile
duonoid 6f5c5e1
tests: Add test_helper
duonoid 3ed377c
Add example: trace_demonstration
duonoid acb435c
Add QueueTime
duonoid 384e331
Add TracerMiddleware
duonoid 6a6fd0a
Add Adapters::Rack::Adapter
duonoid 16e8d32
Add Adapters::Rack
duonoid 4da0f61
Update to 2020 copyright
duonoid b62e0fa
Initialize 'now' later
duonoid 59b5791
Merge branch 'master' into rack-instrumentation--67
duonoid 5e2be00
Adapt to Instrumentation Auto Installer interface
duonoid 423397a
Fix example to use updated Instrumentation Auto Installer
duonoid 0be8aff
Handle errors by setting span.status, leave a TODO and rescue clause
duonoid 14b1198
Allow config[:quantization]
duonoid 9f0e2d8
Remove optional parent context extraction
duonoid fb1bf71
Resolve 'http.base_url' TODO
duonoid ea061d3
Resolve 'resource name' TODO
duonoid 242b403
Resolve 'http.route' TODO
duonoid c3b9319
Note: missing 'span.set_error()' for now
duonoid b110cf1
Resolve FrontendSpan TODOs
duonoid 4cdca21
Optimize allowed_request_headers
duonoid ba86941
Optimize allowed_response_headers()
duonoid e328a7c
Optimize return of EMPTY_HASH frozen constant
duonoid 6544839
Refactor to avoid using dup._call(env)
duonoid 5604391
Merge branch 'master' into rack-instrumentation--67
duonoid efad4af
Merge branch 'master' into rack-instrumentation--67
duonoid 22b69cd
Add Appraisals, integrate into circleci
duonoid 44ddb04
Integrate rubocop, fix violations, add adapters to top-level rake task
duonoid 197ade6
Update example to use new config
duonoid 87e74b8
Rewrite examples
duonoid de91025
Automatically patch Rack::Builder
duonoid e9c021b
Port ddtrace Quantization::HTTP
duonoid 99f44e8
Integrate Util::Quantization
duonoid 33fe594
Revert "Automatically patch Rack::Builder"
duonoid 1ce1bf5
Add missing files needed for Bundler.require
duonoid 8a34ab2
Update Rakefile
duonoid 6344642
Avoid patching config[:application] during installation
duonoid de81be2
Refine/optimize allowed_request_headers
duonoid 5479ad0
Refine/optimize allowed_response_headers
duonoid edb95f9
Avoid circular require
duonoid 1399250
Use SDK.configure to streamline test_helper.rb setup
duonoid 78acca7
Revert "Integrate Util::Quantization"
duonoid a69f94e
Revert "Port ddtrace Quantization::HTTP"
duonoid 70aa352
Fix example/trace_demonstration2.rb to integrate explicitly, with 'use'
duonoid 457e695
Update example/trace_demonstration2.rb documentation
duonoid f78c90e
Optimize allowed_response_headers to avoid using Hash#detect
duonoid c1a3a6e
Simplify allowed_{rack,request}_header_names to inline config
duonoid 7d5fc8b
Optimize to return EMPTY_HASH if allowed_{response,rack_request}_head…
duonoid b447d74
Merge branch 'master' into rack-instrumentation--67
duonoid dcb150f
Adjust to context prop changes
duonoid 845aaa6
Remove unused variables
duonoid f565ad3
Use kind: :server for both frontend and request span
duonoid 7b08085
Make request_span parented by frontend_span
duonoid 8e0e1b4
Implement using helpers to that in_span doesn't have to record and re…
duonoid dabdf02
Cleanup some URL wrapper methods
duonoid 1317d35
Optimize: return without assigning local variable
duonoid caeb3bd
Just use http.{scheme,host,target} (remove url, base_url)
duonoid 3659ead
Inline Rack::Request#fullpath
duonoid af52bd7
Merge remote-tracking branch 'upstream/master' into rack-instrumentat…
duonoid 2c68392
Fix .circleci/config.yml after conflict
duonoid c1a1c2d
Merge remote-tracking branch 'upstream/master' into rack-instrumentat…
duonoid fb3a242
Adjust error handling according to #184
duonoid e763e21
Rewrite to utilize in_span
duonoid e5d15c6
Reduce comments that were more useful in development/review
duonoid 313f576
Merge branch 'master' into rack-instrumentation--67
duonoid 12b6b58
Update http.host to use HTTP_HOST or 'unknown'
duonoid bb3b9c2
Update request_start_time to be number, not timestamp
duonoid bcf940f
Remove request_span comment
duonoid cc14c64
Remove 'service' attribute when creating frontend span
duonoid 16079fa
Merge branch 'master' into rack-instrumentation--67
duonoid 80b2c2d
Change frontend_span to 'http_server.proxy', make request_span :internal
duonoid 85bf829
Merge branch 'master' into rack-instrumentation--67
duonoid 37c9f55
Merge remote-tracking branch 'upstream/master' into rack-instrumentat…
duonoid d3443e3
Merge remote-tracking branch 'upstream/master' into rack-instrumentat…
duonoid File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Adjust error handling according to #184
- Loading branch information
commit fb3a242625f6a2228f9d20b59cc2b6fbd6532566
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Span#record_error
sets the status for us now. If you use the alternate call (that usesin_span
) we won't need this method. If we keep it, it doesn't need to set the status.