Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-add spans to bsp @spans using splat operator #1580

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

plantfansam
Copy link
Contributor

@plantfansam plantfansam commented Jan 24, 2024

When we requeue spans for export after a timeout, we can inadvertently create a nested array in @spans. I believe that this behavior is unintentional, but I could be wrong.

An IRB session that sorta explains what I mean:

irb(main):001:0> x = [1,2]
=> [1, 2]
irb(main):002:0> x.unshift(*[3,4])
=> [3, 4, 1, 2]
irb(main):003:0> x.unshift([5,6])
=> [[5, 6], 3, 4, 1, 2]


@fbogsany fbogsany merged commit 4b37bb3 into open-telemetry:main Jan 24, 2024
55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants