feat: support OTEL_ATTRIBUTE_{COUNT,VALUE_LENGTH}_LIMIT env vars #1292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes open-telemetry#1251 by additionally supporting `OTEL_ATTRIBUTE_COUNT_LIMIT` and `OTEL_ATTRIBUTE_VALUE_LENGTH_LIMIT` as ways to configure span limits. As per spec, the existing model-specific limits (eg: `OTEL_SPAN_ATTRIBUTE_...` env vars) are preferred when they are present. The easiest way to do this was to re-use the handy `config_opt` method in `opentelemetry-common` package, on which we already depend. It made the lines even longer, which is gross, but it works pretty nicely.
ahayworth
requested review from
fbogsany,
mwear,
robertlaurin,
dazuma,
ericmustin,
arielvalentin and
plantfansam
as code owners
ahayworth
added
spec-compliance
fbogsany
approved these changes
Jun 16, 2022
ahayworth
added a commit
to ahayworth/opentelemetry-specification
that referenced
this pull request
Jul 2, 2022
- We now specify adding attributes up-front as preferred in our documentation: open-telemetry/opentelemetry-ruby#1291 - We implement all of the attribute limits described in the spec. The remainder were implemented in: open-telemetry/opentelemetry-ruby#1292 - We have supported the TextMapPropagator for awhile (v0.17, released 2021-04-22) - We have supported `OTEL_SERVICE_NAME` for awhile (v1.0.0rc2, released 2021-06-23) - We support all `OTEL_EXPORTER_{JAEGER,ZIPKIN}` defined in the spec since 2021. - We definitely suppport the Exporter interface (unclear how we could have hit 1.0 without it).
tigrannajaryan
pushed a commit
to open-telemetry/opentelemetry-specification
that referenced
this pull request
Jul 4, 2022
- We now specify adding attributes up-front as preferred in our documentation: open-telemetry/opentelemetry-ruby#1291 - We implement all of the attribute limits described in the spec. The remainder were implemented in: open-telemetry/opentelemetry-ruby#1292 - We have supported the TextMapPropagator for awhile (v0.17, released 2021-04-22) - We have supported `OTEL_SERVICE_NAME` for awhile (v1.0.0rc2, released 2021-06-23) - We support all `OTEL_EXPORTER_{JAEGER,ZIPKIN}` defined in the spec since 2021. - We definitely suppport the Exporter interface (unclear how we could have hit 1.0 without it).
beeme1mr
pushed a commit
to beeme1mr/opentelemetry-specification
that referenced
this pull request
Aug 31, 2022
- We now specify adding attributes up-front as preferred in our documentation: open-telemetry/opentelemetry-ruby#1291 - We implement all of the attribute limits described in the spec. The remainder were implemented in: open-telemetry/opentelemetry-ruby#1292 - We have supported the TextMapPropagator for awhile (v0.17, released 2021-04-22) - We have supported `OTEL_SERVICE_NAME` for awhile (v1.0.0rc2, released 2021-06-23) - We support all `OTEL_EXPORTER_{JAEGER,ZIPKIN}` defined in the spec since 2021. - We definitely suppport the Exporter interface (unclear how we could have hit 1.0 without it).
ChengJinbao
added a commit
to ChengJinbao/opentelemetry-specification
that referenced
this pull request
Nov 16, 2022
- We now specify adding attributes up-front as preferred in our documentation: open-telemetry/opentelemetry-ruby#1291 - We implement all of the attribute limits described in the spec. The remainder were implemented in: open-telemetry/opentelemetry-ruby#1292 - We have supported the TextMapPropagator for awhile (v0.17, released 2021-04-22) - We have supported `OTEL_SERVICE_NAME` for awhile (v1.0.0rc2, released 2021-06-23) - We support all `OTEL_EXPORTER_{JAEGER,ZIPKIN}` defined in the spec since 2021. - We definitely suppport the Exporter interface (unclear how we could have hit 1.0 without it).
joaopgrassi
pushed a commit
to dynatrace-oss-contrib/semantic-conventions
that referenced
this pull request
Mar 21, 2024
- We now specify adding attributes up-front as preferred in our documentation: open-telemetry/opentelemetry-ruby#1291 - We implement all of the attribute limits described in the spec. The remainder were implemented in: open-telemetry/opentelemetry-ruby#1292 - We have supported the TextMapPropagator for awhile (v0.17, released 2021-04-22) - We have supported `OTEL_SERVICE_NAME` for awhile (v1.0.0rc2, released 2021-06-23) - We support all `OTEL_EXPORTER_{JAEGER,ZIPKIN}` defined in the spec since 2021. - We definitely suppport the Exporter interface (unclear how we could have hit 1.0 without it).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1251 by additionally supporting
OTEL_ATTRIBUTE_COUNT_LIMITandOTEL_ATTRIBUTE_VALUE_LENGTH_LIMITas ways to configure span limits. Asper spec, the existing model-specific limits (eg:
OTEL_SPAN_ATTRIBUTE_...env vars) are preferred when they are present.
The easiest way to do this was to re-use the handy
config_optmethodin
opentelemetry-commonpackage, on which we already depend. It madethe lines even longer, which is gross, but it works pretty nicely.