Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor exporter naming #1266

Merged
merged 2 commits into from
May 18, 2022
Merged

Refactor exporter naming #1266

merged 2 commits into from
May 18, 2022

Conversation

robertlaurin
Copy link
Contributor

arielvalentin
arielvalentin reviewed May 18, 2022
View reviewed changes
Copy link
Contributor

@arielvalentin arielvalentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a breaking change right?
Mind using conventional commit messages to reflect that?

@robertlaurin
Copy link
Contributor Author

This is a breaking change right? Mind using conventional commit messages to reflect that?

Neither of these gems have been published, so it's not a breaking change unless someone is pulling right from main 😄

@arielvalentin
Copy link
Contributor

@robertlaurin well then... carry on

@robertlaurin robertlaurin merged commit 113e513 into main May 18, 2022
@robertlaurin robertlaurin deleted the refactor-exporter-naming branch May 18, 2022 20:15
@robertlaurin robertlaurin self-assigned this May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arielvalentin arielvalentin arielvalentin approved these changes

@fbogsany fbogsany Awaiting requested review from fbogsany fbogsany is a code owner

@mwear mwear Awaiting requested review from mwear mwear is a code owner

@dazuma dazuma Awaiting requested review from dazuma dazuma is a code owner

@ericmustin ericmustin Awaiting requested review from ericmustin ericmustin is a code owner

@ahayworth ahayworth Awaiting requested review from ahayworth ahayworth is a code owner

@plantfansam plantfansam Awaiting requested review from plantfansam plantfansam is a code owner

Assignees

@robertlaurin robertlaurin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robertlaurin @arielvalentin