Converted resource to hold Resource attribute than a string #866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codeboten
suggested changes
Jun 29, 2020
There was a problem hiding this comment.
Nice! Thanks for the fix @bitspradp, please add an entry to the changelog for both boto/botocore instrumentations.
Ack @codeboten |
codeboten
approved these changes
Jun 30, 2020
cnnradams
pushed a commit
to cnnradams/opentelemetry-python
that referenced
this pull request
Jul 2, 2020
codeboten
pushed a commit
that referenced
this pull request
Jul 7, 2020
srikanthccv
pushed a commit
to srikanthccv/opentelemetry-python
that referenced
this pull request
Nov 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #817
This PR aims to fix the issue of having the resource attribute in boto and botocore as
stringwhich fails when exported to Jaeger or zipkin.Tests are fixed to reflect these changes by converting resource from
stringtoResource