-
Notifications
You must be signed in to change notification settings - Fork 656
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Instrumentation for asyncpg #814
Instrumentation for asyncpg #814
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good overall, some comments from a first pass:
ext/opentelemetry-ext-asyncpg/src/opentelemetry/ext/asyncpg/__init__.py
Outdated
Show resolved
Hide resolved
ext/opentelemetry-ext-asyncpg/src/opentelemetry/ext/asyncpg/__init__.py
Outdated
Show resolved
Hide resolved
ext/opentelemetry-ext-asyncpg/src/opentelemetry/ext/asyncpg/__init__.py
Outdated
Show resolved
Hide resolved
ext/opentelemetry-ext-asyncpg/src/opentelemetry/ext/asyncpg/__init__.py
Outdated
Show resolved
Hide resolved
ext/opentelemetry-ext-asyncpg/src/opentelemetry/ext/asyncpg/__init__.py
Outdated
Show resolved
Hide resolved
ext/opentelemetry-ext-asyncpg/src/opentelemetry/ext/asyncpg/__init__.py
Outdated
Show resolved
Hide resolved
ext/opentelemetry-ext-asyncpg/src/opentelemetry/ext/asyncpg/__init__.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, a couple non-blocking comments
ext/opentelemetry-ext-asyncpg/src/opentelemetry/ext/asyncpg/__init__.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Small comment about tox
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! A few small changes.
Hi everyone!
Asyncpg instrumentation. Tested on versions 0.12.0 and 0.20.1