docs: Add missing dependencies and fix django #657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add missing sqlalchemy and django dependencies - Configure django in docs/conf.py to avoid non configured exeception
lzchen
reviewed
May 7, 2020
| import django | ||
| from django.conf import settings | ||
|
|
||
| settings.configure() |
There was a problem hiding this comment.
Can you explain a bit more about the exception and how this solves it?
There was a problem hiding this comment.
Sure, I added a comment with more information in 5de0516.
toumorokoshi
approved these changes
May 8, 2020
docs-requirements.txt
Outdated
| @@ -13,5 +14,6 @@ prometheus_client>=0.5.0,<1.0.0 | |||
| psycopg2-binary>=2.7.3.1 | |||
| pymongo~=3.1 | |||
| redis>=2.6 | |||
| sqlalchemy | |||
There was a problem hiding this comment.
does this have a floor version too?
There was a problem hiding this comment.
I just copy and pasted from
@codeboten do you have more information here?
lzchen
approved these changes
May 8, 2020
srikanthccv
pushed a commit
to srikanthccv/opentelemetry-python
that referenced
this pull request
Nov 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview here https://opentelemetry-python-mauricio.readthedocs.io/en/latest/.